skia_commit_hash.h

skia_commit_hash.h

shows up in chrome://gpu

makes use of build/util/lastchange.py

BUG=235455
Committed: https://crrev.com/5cacab3ad1c742e08fc26e666171e6b3e4bd99fe
Cr-Commit-Position: refs/heads/master@{#408719}

[hal.canary, 2016-07-26 16:02:17]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 16:02:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-07-26 16:03:45]

halcanary@google.com changed reviewers:
+ hcm@google.com, mtklein@chromium.org, mtklein@google.com

[hal.canary, 2016-07-26 16:03:46]

still need to add GYP version.  Is that necessary?

[mtklein, 2016-07-26 16:11:48]

https://codereview.chromium.org/2187533002/diff/1/skia/commit_hash.py
File skia/commit_hash.py (right):

https://codereview.chromium.org/2187533002/diff/1/skia/commit_hash.py#newcode26
skia/commit_hash.py:26: commit = 'UNKNOWN'
Is failure expected to happen somewhere?  Wouldn't you rather this script, and
the build step, fail?

[commit-bot: I haz the power, 2016-07-26 16:16:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 16:16:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hcm, 2016-07-26 16:22:37]

On 2016/07/26 16:03:46, Hal Canary wrote:
> still need to add GYP version.  Is that necessary?

Let's skip the GYP version- Chrome trunk builds are all migrated to GN and this
is a nice-to-have (doesn't need to be merged back to milestone branch builds).

[hal.canary, 2016-07-26 16:30:38]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 16:30:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-07-26 16:32:27]

Description was changed from

==========
skia/ext/skia_commit_hash

shows up in chrome://gpu

BUG=
==========

to

==========
skia/ext/skia_commit_hash

shows up in chrome://gpu

BUG=235455
==========

[commit-bot: I haz the power, 2016-07-26 16:36:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 16:36:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)

[hal.canary, 2016-07-26 16:42:01]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[hal.canary, 2016-07-26 16:42:07]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-07-26 16:42:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 16:48:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 16:48:03]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  win8_chromium_gyp_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gyp...)

[hal.canary, 2016-07-26 17:35:00]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 17:35:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 17:41:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 17:41:24]

Dry run: Try jobs failed on following builders:
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)

[hal.canary, 2016-07-26 17:41:54]

Patchset #3 (id:60001) has been deleted

[hal.canary, 2016-07-26 17:41:58]

Patchset #2 (id:40001) has been deleted

[hal.canary, 2016-07-26 17:42:03]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 17:42:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-07-26 17:42:24]

The CQ bit was unchecked by halcanary@google.com

[hal.canary, 2016-07-26 17:43:33]

Patchset #2 (id:80001) has been deleted

[hal.canary, 2016-07-26 17:43:52]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 17:44:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-07-26 17:51:13]

Description was changed from

==========
skia/ext/skia_commit_hash

shows up in chrome://gpu

BUG=235455
==========

to

==========
skia/ext/skia_commit_hash

shows up in chrome://gpu

If git fails, you get "UNKNOWN"

On gyp builds, you get ""

BUG=235455
==========

[commit-bot: I haz the power, 2016-07-26 18:00:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 18:00:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[hal.canary, 2016-07-26 18:18:26]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[hal.canary, 2016-07-26 18:18:31]

Patchset #3 (id:120001) has been deleted

[hal.canary, 2016-07-26 18:18:36]

Patchset #2 (id:100001) has been deleted

[commit-bot: I haz the power, 2016-07-26 18:19:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 19:05:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 19:05:01]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[hal.canary, 2016-07-26 19:18:25]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 19:18:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 20:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 20:32:57]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[hal.canary, 2016-07-26 21:20:28]

On 2016/07/26 16:22:37, hcm wrote:
> On 2016/07/26 16:03:46, Hal Canary wrote:
> > still need to add GYP version.  Is that necessary?
> 
> Let's skip the GYP version- Chrome trunk builds are all migrated to GN and
this
> is a nice-to-have (doesn't need to be merged back to milestone branch builds).

Done. 

I don't have time to fiddle with getting this to build. Maybe someone else can
take a look?

[hal.canary, 2016-07-26 21:20:32]

On 2016/07/26 16:22:37, hcm wrote:
> On 2016/07/26 16:03:46, Hal Canary wrote:
> > still need to add GYP version.  Is that necessary?
> 
> Let's skip the GYP version- Chrome trunk builds are all migrated to GN and
this
> is a nice-to-have (doesn't need to be merged back to milestone branch builds).

Done. 

I don't have time to fiddle with getting this to build. Maybe someone else can
take a look?

[hcm, 2016-07-28 16:52:48]

On 2016/07/26 16:11:48, mtklein wrote:
> https://codereview.chromium.org/2187533002/diff/1/skia/commit_hash.py
> File skia/commit_hash.py (right):
> 
>
https://codereview.chromium.org/2187533002/diff/1/skia/commit_hash.py#newcode26
> skia/commit_hash.py:26: commit = 'UNKNOWN'
> Is failure expected to happen somewhere?  Wouldn't you rather this script, and
> the build step, fail?

Depending on the bot, git cannot always be counted on (source: borenet), so I
suppose we do need to handle this case and load the value with something vs fail
the build.

[hal.canary, 2016-07-28 20:14:32]

Patchset #4 (id:180001) has been deleted

[hal.canary, 2016-07-28 20:19:51]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 20:20:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 21:16:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 21:16:59]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2016-07-28 21:31:57]

PTAL.  passes all tests now.

[hcm, 2016-07-29 12:26:32]

hcm@google.com changed reviewers:
+ zmo@chromium.org

[hcm, 2016-07-29 12:27:42]

On 2016/07/28 21:31:57, Hal Canary wrote:
> PTAL.  passes all tests now.

+zmo since we're making a change to about:gpu

[Zhenyao Mo, 2016-07-29 15:18:31]

On 2016/07/29 12:27:42, hcm wrote:
> On 2016/07/28 21:31:57, Hal Canary wrote:
> > PTAL.  passes all tests now.
> 
> +zmo since we're making a change to about:gpu

content/browser/gpu lgtm

[hcm, 2016-07-29 15:39:03]

On 2016/07/29 15:18:31, Zhenyao Mo wrote:
> On 2016/07/29 12:27:42, hcm wrote:
> > On 2016/07/28 21:31:57, Hal Canary wrote:
> > > PTAL.  passes all tests now.
> > 
> > +zmo since we're making a change to about:gpu
> 
> content/browser/gpu lgtm

thanks, lgtm

[mtklein_C, 2016-07-29 15:46:30]

https://codereview.chromium.org/2187533002/diff/200001/skia/BUILD.gn
File skia/BUILD.gn (right):

https://codereview.chromium.org/2187533002/diff/200001/skia/BUILD.gn#newcode299
skia/BUILD.gn:299: action("generate_commit_hash") {
How does chrome://version/ do this, and why do we not do the same?

[hal.canary, 2016-07-29 17:22:15]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[hal.canary, 2016-07-29 17:22:21]

Patchset #5 (id:220001) has been deleted

[commit-bot: I haz the power, 2016-07-29 17:22:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-07-29 17:24:15]

Description was changed from

==========
skia/ext/skia_commit_hash

shows up in chrome://gpu

If git fails, you get "UNKNOWN"

On gyp builds, you get ""

BUG=235455
==========

to

==========
skia_commit_hash.h

shows up in chrome://gpu

makes use of build/util/lastchange.py

BUG=235455
==========

[commit-bot: I haz the power, 2016-07-29 17:28:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 17:28:48]

Dry run: Try jobs failed on following builders:
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)

[hal.canary, 2016-07-29 17:35:09]

Patchset #5 (id:240001) has been deleted

[hal.canary, 2016-07-29 18:08:01]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 18:08:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-07-29 19:06:44]

lgtm

[commit-bot: I haz the power, 2016-07-29 19:10:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 19:11:00]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2016-07-29 19:11:44]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2016-07-29 19:11:44]

The patchset sent to the CQ was uploaded after l-g-t-m from hcm@google.com,
zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2187533002/#ps260001
(title: "2016-07-29 (Friday) 14:04:15 EDT")

[commit-bot: I haz the power, 2016-07-29 19:12:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 19:23:36]

Description was changed from

==========
skia_commit_hash.h

shows up in chrome://gpu

makes use of build/util/lastchange.py

BUG=235455
==========

to

==========
skia_commit_hash.h

shows up in chrome://gpu

makes use of build/util/lastchange.py

BUG=235455
==========

[commit-bot: I haz the power, 2016-07-29 19:23:37]

Committed patchset #5 (id:260001)

[commit-bot: I haz the power, 2016-07-29 19:25:34]

Description was changed from

==========
skia_commit_hash.h

shows up in chrome://gpu

makes use of build/util/lastchange.py

BUG=235455
==========

to

==========
skia_commit_hash.h

shows up in chrome://gpu

makes use of build/util/lastchange.py

BUG=235455

Committed: https://crrev.com/5cacab3ad1c742e08fc26e666171e6b3e4bd99fe
Cr-Commit-Position: refs/heads/master@{#408719}
==========

[commit-bot: I haz the power, 2016-07-29 19:25:35]

Patchset 5 (id:??) landed as
https://crrev.com/5cacab3ad1c742e08fc26e666171e6b3e4bd99fe
Cr-Commit-Position: refs/heads/master@{#408719}