Issue 218753005: Replace set_map_and_elements by MigrateToMap-based SetMapAndElements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218753005: Replace set_map_and_elements by MigrateToMap-based SetMapAndElements (Closed)

Created:
6 years, 8 months ago by Toon Verwaest

Modified:
6 years, 8 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Replace set_map_and_elements by MigrateToMap-based SetMapAndElements BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20364

Patch Set 2 : Addressed comment #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -47 lines)			Patch
M	src/api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	1	2 chunks	+4 lines, -5 lines	0 comments	Download
M	src/objects.cc	View	1	5 chunks	+11 lines, -4 lines	0 comments	Download
M	src/objects-inl.h	View	1	1 chunk	+14 lines, -21 lines	0 comments	Download
M	src/runtime.cc	View	1	3 chunks	+13 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with a nit: https://codereview.chromium.org/218753005/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/218753005/diff/1/src/objects-inl.h#newcode1715 src/objects-inl.h:1715: WRITE_BARRIER(obj->GetHeap(), obj, kElementsOffset, val); What ...

6 years, 8 months ago (2014-03-31 12:35:46 UTC) #2

Toon Verwaest

Addressed comment https://codereview.chromium.org/218753005/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/218753005/diff/1/src/objects-inl.h#newcode1715 src/objects-inl.h:1715: WRITE_BARRIER(obj->GetHeap(), obj, kElementsOffset, val); That makes more ...

6 years, 8 months ago (2014-03-31 12:37:51 UTC) #3

Toon Verwaest

6 years, 8 months ago (2014-03-31 15:30:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20364 (presubmit successful).

Expand Messages | Collapse Messages

Issue 218753005: Replace set_map_and_elements by MigrateToMap-based SetMapAndElements (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comment #

Messages