Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 218753003: Fix crash when a demoted FORM element is moved into a ShadowRoot. (Closed)

Created:
6 years, 8 months ago by tkent
Modified:
6 years, 8 months ago
Reviewers:
keishi, esprehn
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Fix crash when a demoted FORM element is moved into a ShadowRoot. We can't assume the parent node of a demoted FORM element always have its renderer if we use ShadowRoots. BUG=343463 TEST=automated Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170737

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, --1 lines) Patch
A LayoutTests/fast/dom/shadow/shadowdom-for-unknown-with-form.html View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/shadowdom-for-unknown-with-form-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tkent
esprehn@, would you review this please?
6 years, 8 months ago (2014-03-31 10:14:51 UTC) #1
tkent
+keishi
6 years, 8 months ago (2014-04-01 03:32:41 UTC) #2
keishi
lgtm
6 years, 8 months ago (2014-04-03 05:09:04 UTC) #3
tkent
Thanks!
6 years, 8 months ago (2014-04-03 05:12:19 UTC) #4
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 8 months ago (2014-04-03 05:12:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/218753003/40001
6 years, 8 months ago (2014-04-03 05:12:25 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 05:14:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-03 05:14:41 UTC) #8
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 8 months ago (2014-04-03 05:15:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/218753003/40001
6 years, 8 months ago (2014-04-03 05:15:12 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 05:54:48 UTC) #11
Message was sent while issue was closed.
Change committed as 170737

Powered by Google App Engine
This is Rietveld 408576698