tools/gn/loader_unittest.cc - Issue 2187523003: Allow creation and modification of scopes in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/loader_unittest.cc

Issue 2187523003: Allow creation and modification of scopes in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/loader_unittest.cc

diff --git a/tools/gn/loader_unittest.cc b/tools/gn/loader_unittest.cc

index c6cdbdb66b89b0c2f0aa7d6228e1be2f0df7433a..20b8609d1aa92b20dac1bf19a7e54ccc8e05b71a 100644

--- a/tools/gn/loader_unittest.cc

+++ b/tools/gn/loader_unittest.cc

@@ -96,7 +96,7 @@ bool MockInputFileManager::HasTwoPending(const SourceFile& f1,

}

void MockInputFileManager::IssueAllPending() {

- BlockNode block; // Default response.

+ BlockNode block(BlockNode::DISCARDS_RESULT); // Default response.

for (const auto& cur : pending_) {

CannedResponseMap::const_iterator found = canned_responses_.find(cur.first);

« no previous file with comments | « tools/gn/functions.cc ('k') | tools/gn/operators.cc » ('j') | no next file with comments »