tools/gn/function_forward_variables_from.cc - Issue 2187523003: Allow creation and modification of scopes in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/function_forward_variables_from.cc

Issue 2187523003: Allow creation and modification of scopes in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/function_forward_variables_from.cc

diff --git a/tools/gn/function_forward_variables_from.cc b/tools/gn/function_forward_variables_from.cc

index 8f3b90dec716655748087a65a1ccb368275af065..8c7a558224e25ea0b21e96b3dff386e37ed8d223 100644

--- a/tools/gn/function_forward_variables_from.cc

+++ b/tools/gn/function_forward_variables_from.cc

@@ -183,7 +183,8 @@ Value RunForwardVariablesFrom(Scope* scope,

}

// Extract the source scope.

- Value* value = scope->GetMutableValue(identifier->value().value(), true);

+ Value* value = scope->GetMutableValue(

+ identifier->value().value(), Scope::SEARCH_NESTED, true);

if (!value) {

*err = Err(identifier, "Undefined identifier.");

return Value();

« no previous file with comments | « tools/gn/function_foreach.cc ('k') | tools/gn/functions.cc » ('j') | no next file with comments »