Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 2187493004: Add a generated ComputedStyleBase class that ComputedStyle extends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_visibility_enum_class_rebase
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn
index 70c7179de57469f3c449a2ef7ced437b2daf540b..cf4efc96138d422093a33b12556a1bc12c8a1d91 100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -369,6 +369,11 @@ target(link_target_type, "core_generated") {
sources += generated_core_dictionary_files
sources += [
+ # Generated from make_base_computed_style.py
+ "$blink_core_output_dir/BaseComputedStyle.cpp",
+ "$blink_core_output_dir/BaseComputedStyle.h",
+ "$blink_core_output_dir/BaseComputedStyleConstants.h",
+
# Additional .cpp files for HashTools.h
"$blink_core_output_dir/CSSPropertyNames.cpp",
"$blink_core_output_dir/CSSValueKeywords.cpp",
@@ -615,6 +620,7 @@ action("generated_testing_idls_internal_runtime_flags") {
# GYP version: WebKit/Source/core/core_generated.gyp:make_core_generated
group("make_core_generated") {
public_deps = [
+ ":make_core_generated_base_computed_style",
":make_core_generated_bison",
":make_core_generated_css_primitive_value_unit_trie",
":make_core_generated_css_property_metadata",
@@ -651,6 +657,21 @@ group("make_core_generated") {
]
}
+# "BaseComputedStyle" in make_core_generated from GYP.
+css_properties("make_core_generated_base_computed_style") {
+ script = "../build/scripts/make_base_computed_style.py"
+ other_inputs = [
+ "../build/scripts/templates/BaseComputedStyle.cpp.tmpl",
+ "../build/scripts/templates/BaseComputedStyle.h.tmpl",
+ "../build/scripts/templates/BaseComputedStyleConstants.h.tmpl",
+ ]
+ outputs = [
+ "$blink_core_output_dir/BaseComputedStyle.cpp",
+ "$blink_core_output_dir/BaseComputedStyle.h",
+ "$blink_core_output_dir/BaseComputedStyleConstants.h",
+ ]
+}
+
# "CSSPropertyNames" in make_core_generated from GYP.
css_properties("make_core_generated_css_property_names") {
script = "../build/scripts/make_css_property_names.py"

Powered by Google App Engine
This is Rietveld 408576698