Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2187483002: Revert of [Android] Reland Galaxy s5 perf bots to run using platform mode. (Closed)

Created:
4 years, 4 months ago by jbudorick
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of [Android] Reland Galaxy s5 perf bots to run using platform mode. (patchset #1 id:1 of https://codereview.chromium.org/2177863004/ ) Reason for revert: the sharded perf tests step fails when one or more devices are blacklisted. Original issue's description: > [Android] Reland Galaxy s5 perf bots to run using platform mode. > > BUG=615157, 630627, 630640 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/772e098a3f629dfeadab58212623a07e54ee902a TBR=stip@chromium.org,rnephew@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=615157, 630627, 630640 Committed: https://chromium.googlesource.com/chromium/tools/build/+/93b972af676e8098ebc020db5600b1197a761982

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M scripts/slave/recipes/android/perf.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 3 chunks +2 lines, -5 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 3 chunks +2 lines, -5 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbudorick
Created Revert of [Android] Reland Galaxy s5 perf bots to run using platform mode.
4 years, 4 months ago (2016-07-26 13:43:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187483002/1
4 years, 4 months ago (2016-07-26 13:44:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/93b972af676e8098ebc020db5600b1197a761982
4 years, 4 months ago (2016-07-26 13:44:13 UTC) #5
rnephew (Reviews Here)
4 years, 4 months ago (2016-07-26 16:40:35 UTC) #6
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2184803002/ by rnephew@chromium.org.

The reason for reverting is: Fixed with
https://codereview.chromium.org/2187513002/.

Powered by Google App Engine
This is Rietveld 408576698