Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3741)

Unified Diff: chrome/browser/chromeos/login/hwid_checker.cc

Issue 2187473006: No "Factory error" splashscreen on ChromeOS VMs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: No "Factory error" splashscreen on ChromeOS VMs Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/hwid_checker.cc
diff --git a/chrome/browser/chromeos/login/hwid_checker.cc b/chrome/browser/chromeos/login/hwid_checker.cc
index 4509672ba2b3608ff3da44187be03d4264dca5c5..334e52035cc01088080119d129c46a00fca6c716 100644
--- a/chrome/browser/chromeos/login/hwid_checker.cc
+++ b/chrome/browser/chromeos/login/hwid_checker.cc
@@ -133,9 +133,20 @@ bool IsMachineHWIDCorrect() {
std::string system_vendor;
stats->GetMachineStatistic(chromeos::system::kSystemVendorKey,
&system_vendor);
- LOG(ERROR) << "Machine has malformed HWID '" << hwid << "'. "
- << "The system vendor is '" << system_vendor << "'.";
- return false;
+ std::string firmware_type;
+ const bool non_chrome_firmware =
+ stats->GetMachineStatistic(chromeos::system::kFirmwareTypeKey,
+ &firmware_type) &&
+ firmware_type == system::kFirmwareTypeValueNonchrome;
+ if (non_chrome_firmware) {
+ LOG(WARNING) << "Detected non-Chrome firmware with malformed HWID '"
+ << hwid << "', assuming VM environment. "
+ << "The system vendor is '" << system_vendor << "'.";
+ } else {
+ LOG(ERROR) << "Machine has malformed HWID '" << hwid << "'. "
+ << "The system vendor is '" << system_vendor << "'.";
+ return false;
+ }
}
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698