No "Factory error" splashscreen on ChromeOS VMs

No "Factory error" splashscreen on ChromeOS VMs

If the HWID is invalid (for instance, "unknown") and the firmware ID is non-Chrome ("nonchrome") then assume that we're running in a VM and do not report a factory
error. A warning message is added to the log.

BUG=b:30155895
Committed: https://crrev.com/7077c9c09ee068bfeb7623c8ac58e7a21b7143c8
Cr-Commit-Position: refs/heads/master@{#408870}

[norvez, 2016-07-27 14:48:56]

Description was changed from

==========
No "Factory error" splashscreen on ChromeOS VMs

If the HWID is invalid and the firmware ID is non-Chrome ("unknown")
then assume that we're running in a VM and do not report a factory
error. A warning message is sent to the log.

BUG=b:30155895
==========

to

==========
No "Factory error" splashscreen on ChromeOS VMs

If the HWID is invalid and the firmware ID is non-Chrome ("unknown")
then assume that we're running in a VM and do not report a factory
error. A warning message is sent to the log.

BUG=b:30155895
==========

[norvez, 2016-07-27 14:48:56]

norvez@chromium.org changed reviewers:
+ hungte@chromium.org, rspangler@chromium.org, vpalatin@chromium.org

[norvez, 2016-07-27 14:52:36]

Hi,

Proposed CL for b/30155895 to avoid HWID check failures in VMs. This is done at
the Chrome level rather than crossystem after review at
https://chromium-review.googlesource.com/#/c/363330/
PTAL :)

[Hung-Te, 2016-07-27 15:01:32]

Only few comments to the commit message:

> If the HWID is invalid and the firmware ID is non-Chrome ("unknown")

 If  the HWID is empty and the firmware type is non-Chrome ("nonchrome")


P.S: I think on VM the HWID is always empty. Do you want to assume it's VM
whenever HWID is invalid, or just the case of empty?

[norvez, 2016-07-27 15:28:48]

On 2016/07/27 15:01:32, Hung-Te wrote:
> Only few comments to the commit message:
> 
> > If the HWID is invalid and the firmware ID is non-Chrome ("unknown")
> 
>  If  the HWID is empty and the firmware type is non-Chrome ("nonchrome")

Woops, good catch, thanks! Will fix...

> 
> P.S: I think on VM the HWID is always empty. Do you want to assume it's VM
> whenever HWID is invalid, or just the case of empty?

I think statistics_provider sets it to "unknown" in that case:
https://cs.chromium.org/chromium/src/chromeos/system/statistics_provider.cc?r...

I could check for "unknown" but I think there's a bit more work to do at the
same time to fully support VMs, see crbug.com/585514 and crbug.com/585515 for
example.
There's also a bit of cleanup to do to in statistics_provider, we should handle
ARM systems that don't have "/sys/class/dmi/id/sys_vendor" and a few other
things. All in all I think that should be in a separate CL, and we could add
some tests for statistics_provider at the same time. WDYT?

[Hung-Te, 2016-07-27 15:31:55]

Hmmm. In that case I'd agree to move on with your current version.

Meanwhile I'd like to revise my previous feedback to

 If the HWID is invalid (for instance, "unknown") and the firmware type is
non-Chrome

[norvez, 2016-07-27 15:46:56]

Description was changed from

==========
No "Factory error" splashscreen on ChromeOS VMs

If the HWID is invalid and the firmware ID is non-Chrome ("unknown")
then assume that we're running in a VM and do not report a factory
error. A warning message is sent to the log.

BUG=b:30155895
==========

to

==========
No "Factory error" splashscreen on ChromeOS VMs

If the HWID is invalid (for instance, "unknown") and the firmware ID is
non-Chrome ("nonchrome") then assume that we're running in a VM and do not
report a factory
error. A warning message is added to the log.

BUG=b:30155895
==========

[norvez, 2016-07-27 15:50:20]

On 2016/07/27 15:31:55, Hung-Te wrote:
> Hmmm. In that case I'd agree to move on with your current version.
> 
> Meanwhile I'd like to revise my previous feedback to
> 
>  If the HWID is invalid (for instance, "unknown") and the firmware type is
> non-Chrome

Thanks, I've modified the commit message. I'll try to come up with another CL to
do the more invasive changes to that would help VM support.

[norvez, 2016-07-28 08:58:36]

norvez@chromium.org changed reviewers:
+ dzhioev@chromium.org

[norvez, 2016-07-28 09:00:45]

Forgot to add an owner to reviewers!

[vpalatin, 2016-07-28 09:10:41]

vpalatin@google.com changed reviewers:
+ vpalatin@google.com

[vpalatin, 2016-07-28 09:10:42]

lgtm

[Hung-Te, 2016-07-28 09:12:22]

lgtm

[Hung-Te, 2016-07-28 09:12:25]

lgtm

[norvez, 2016-07-28 09:13:04]

The CQ bit was checked by norvez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 09:13:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 09:47:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 09:47:58]

Dry run: This issue passed the CQ dry run.

[dzhioev (left Google), 2016-07-30 01:20:03]

LGTM

[norvez, 2016-07-30 08:34:29]

The CQ bit was checked by norvez@chromium.org

[commit-bot: I haz the power, 2016-07-30 08:34:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 09:14:42]

Description was changed from

==========
No "Factory error" splashscreen on ChromeOS VMs

If the HWID is invalid (for instance, "unknown") and the firmware ID is
non-Chrome ("nonchrome") then assume that we're running in a VM and do not
report a factory
error. A warning message is added to the log.

BUG=b:30155895
==========

to

==========
No "Factory error" splashscreen on ChromeOS VMs

If the HWID is invalid (for instance, "unknown") and the firmware ID is
non-Chrome ("nonchrome") then assume that we're running in a VM and do not
report a factory
error. A warning message is added to the log.

BUG=b:30155895
==========

[commit-bot: I haz the power, 2016-07-30 09:14:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-30 09:16:21]

Description was changed from

==========
No "Factory error" splashscreen on ChromeOS VMs

If the HWID is invalid (for instance, "unknown") and the firmware ID is
non-Chrome ("nonchrome") then assume that we're running in a VM and do not
report a factory
error. A warning message is added to the log.

BUG=b:30155895
==========

to

==========
No "Factory error" splashscreen on ChromeOS VMs

If the HWID is invalid (for instance, "unknown") and the firmware ID is
non-Chrome ("nonchrome") then assume that we're running in a VM and do not
report a factory
error. A warning message is added to the log.

BUG=b:30155895

Committed: https://crrev.com/7077c9c09ee068bfeb7623c8ac58e7a21b7143c8
Cr-Commit-Position: refs/heads/master@{#408870}
==========

[commit-bot: I haz the power, 2016-07-30 09:16:23]

Patchset 2 (id:??) landed as
https://crrev.com/7077c9c09ee068bfeb7623c8ac58e7a21b7143c8
Cr-Commit-Position: refs/heads/master@{#408870}