DescriptionRevert of Make allocator shim the default for Windows. (patchset #1 id:1 of https://codereview.chromium.org/2183093002/ )
Reason for revert:
Causes Nacl to assert _CrtIsValidHeapPointer(block) and then subsequently hang browser_tests.
First failure:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/51018
PPAPINaClNewlibTest.MessageHandler
ChromeServiceWorkerFetchPPAPIPrivateTest.OtherOriginCORSCredentials
PPAPINaClNewlibTest.NetAddressPrivate
ChromeServiceWorkerFetchPPAPIPrivateTest.OtherOrigin
PPAPINaClNewlibTest.NetworkMonitor
And more.
Original issue's description:
> Make allocator shim the default for Windows.
>
> BUG=550886
>
> patch from issue 2164653002 at patchset 40001 (http://crrev.com/2164653002#ps40001)
>
> Committed: https://crrev.com/60292df5e4ed2fb3edd2c6efe32d6944ab059696
> Cr-Commit-Position: refs/heads/master@{#407915}
TBR=primiano@chromium.org,wfh@chromium.org,brettw@chromium.org,chrisha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=550886
Committed: https://crrev.com/21e62b59aac081572bc74e14e88ccdf9011b06d7
Cr-Commit-Position: refs/heads/master@{#408028}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|