Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2187473005: Revert of Make allocator shim the default for Windows. (Closed)

Created:
4 years, 4 months ago by robliao
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make allocator shim the default for Windows. (patchset #1 id:1 of https://codereview.chromium.org/2183093002/ ) Reason for revert: Causes Nacl to assert _CrtIsValidHeapPointer(block) and then subsequently hang browser_tests. First failure: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/51018 PPAPINaClNewlibTest.MessageHandler ChromeServiceWorkerFetchPPAPIPrivateTest.OtherOriginCORSCredentials PPAPINaClNewlibTest.NetAddressPrivate ChromeServiceWorkerFetchPPAPIPrivateTest.OtherOrigin PPAPINaClNewlibTest.NetworkMonitor And more. Original issue's description: > Make allocator shim the default for Windows. > > BUG=550886 > > patch from issue 2164653002 at patchset 40001 (http://crrev.com/2164653002#ps40001) > > Committed: https://crrev.com/60292df5e4ed2fb3edd2c6efe32d6944ab059696 > Cr-Commit-Position: refs/heads/master@{#407915} TBR=primiano@chromium.org,wfh@chromium.org,brettw@chromium.org,chrisha@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=550886 Committed: https://crrev.com/21e62b59aac081572bc74e14e88ccdf9011b06d7 Cr-Commit-Position: refs/heads/master@{#408028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/config/allocator.gni View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
robliao
Created Revert of Make allocator shim the default for Windows.
4 years, 4 months ago (2016-07-27 02:59:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187473005/1
4 years, 4 months ago (2016-07-27 02:59:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 03:00:26 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 03:02:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21e62b59aac081572bc74e14e88ccdf9011b06d7
Cr-Commit-Position: refs/heads/master@{#408028}

Powered by Google App Engine
This is Rietveld 408576698