Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2187473003: Remove #includes of "xxx_google_chrome_strings.h". (Closed)

Created:
4 years, 4 months ago by Peter Kasting
Modified:
4 years, 4 months ago
Reviewers:
sdefresne, sky
CC:
chromium-reviews, msramek+watch_chromium.org, sadrul, mlamouri+watch-geolocation_chromium.org, droger+watchlist_chromium.org, michaelpg+watch-md-settings_chromium.org, tfarina, vabr+watchlistpasswordmanager_chromium.org, sdefresne+watchlist_chromium.org, raymes+watch_chromium.org, gcasto+watchlist_chromium.org, asvitkine+watch_chromium.org, blundell+watchlist_chromium.org, kalyank, markusheintz_, stevenjb+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, Michael van Ouwerkerk, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove #includes of "xxx_google_chrome_strings.h". These only provide #defines for the IDs of relevant strings. The values are the same as in the corresponding "xxx_chromium_strings.h" files, so only one is necessary, regardless of whether the files will be compiled branded as Chromium or Google Chrome. The canonical #include is the "chromium" one, so leave only that .h everywhere. BUG=none TEST=none Committed: https://crrev.com/6b583ae3c4dada4650d7a370dddf524402deae1b Cr-Commit-Position: refs/heads/master@{#408210}

Patch Set 1 #

Patch Set 2 : Fix bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/session_crashed_infobar_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/session_crashed_bubble_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/crashes_ui.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/about_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/signin_create_profile_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/version_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/crash/core/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/crash/core/browser/crashes_ui_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/error_page/common/localized_error.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/geolocation/omnibox_geolocation_authorization_alert.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/translate/never_translate_infobar_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/crashes_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/flags_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/webui/version_ui.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
Peter Kasting
sky: chrome/browser sdefresne: components, ios This should basically be a rubber-stamp.
4 years, 4 months ago (2016-07-26 21:51:39 UTC) #9
sky
LGTM
4 years, 4 months ago (2016-07-26 23:20:02 UTC) #12
sdefresne
lgtm
4 years, 4 months ago (2016-07-27 07:53:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187473003/20001
4 years, 4 months ago (2016-07-27 19:10:51 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 19:15:30 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 19:18:43 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b583ae3c4dada4650d7a370dddf524402deae1b
Cr-Commit-Position: refs/heads/master@{#408210}

Powered by Google App Engine
This is Rietveld 408576698