Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2187473002: [headless] Add option to disable sandbox from API (Closed)

Created:
4 years, 4 months ago by altimin
Modified:
4 years, 4 months ago
Reviewers:
Sami
CC:
chromium-reviews, alex clarke (OOO till 29th), Eric Seckler
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[headless] Add option to disable sandbox from API R=skyostil@chromium.org BUG=546953 Committed: https://crrev.com/5a57f8bf262dbf7a526c05ad4cccaae710f2983f Cr-Commit-Position: refs/heads/master@{#407789}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Enable sandbox by default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M headless/lib/headless_content_main_delegate.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M headless/public/headless_browser.h View 2 chunks +5 lines, -0 lines 0 comments Download
M headless/public/headless_browser.cc View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
altimin
4 years, 4 months ago (2016-07-26 13:23:21 UTC) #2
Sami
lgtm with one comment. https://codereview.chromium.org/2187473002/diff/1/headless/public/headless_browser.h File headless/public/headless_browser.h (right): https://codereview.chromium.org/2187473002/diff/1/headless/public/headless_browser.h#newcode118 headless/public/headless_browser.h:118: bool disable_sandbox; Doesn't seem to ...
4 years, 4 months ago (2016-07-26 13:53:21 UTC) #3
altimin
https://codereview.chromium.org/2187473002/diff/1/headless/public/headless_browser.h File headless/public/headless_browser.h (right): https://codereview.chromium.org/2187473002/diff/1/headless/public/headless_browser.h#newcode118 headless/public/headless_browser.h:118: bool disable_sandbox; On 2016/07/26 13:53:21, Sami wrote: > Doesn't ...
4 years, 4 months ago (2016-07-26 13:57:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187473002/20001
4 years, 4 months ago (2016-07-26 13:57:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 14:29:32 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 14:32:13 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5a57f8bf262dbf7a526c05ad4cccaae710f2983f
Cr-Commit-Position: refs/heads/master@{#407789}

Powered by Google App Engine
This is Rietveld 408576698