Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: net/quic/crypto/quic_crypto_server_config.cc

Issue 2187463004: Add a new flag to require QUIC handshake confirmation, but only for versions before 33 FLAGS_quic_r… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@128425078
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/crypto_server_test.cc ('k') | net/quic/quic_crypto_server_stream_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/quic_crypto_server_config.cc
diff --git a/net/quic/crypto/quic_crypto_server_config.cc b/net/quic/crypto/quic_crypto_server_config.cc
index a26088d2d18160779d743dd2519518de4869a65d..38fddd0489c324686489e7b26cc72cf7370732b3 100644
--- a/net/quic/crypto/quic_crypto_server_config.cc
+++ b/net/quic/crypto/quic_crypto_server_config.cc
@@ -1219,7 +1219,8 @@ void QuicCryptoServerConfig::EvaluateClientHelloAfterGetProof(
// If we hit this block, the server nonce was empty. If we're requiring
// handshake confirmation for DoS reasons and there's no server nonce present,
// reject the CHLO.
- if (FLAGS_quic_require_handshake_confirmation) {
+ if (FLAGS_quic_require_handshake_confirmation ||
+ FLAGS_quic_require_handshake_confirmation_pre33) {
info->reject_reasons.push_back(SERVER_NONCE_REQUIRED_FAILURE);
helper.ValidationComplete(QUIC_NO_ERROR, "");
return;
« no previous file with comments | « net/quic/crypto/crypto_server_test.cc ('k') | net/quic/quic_crypto_server_stream_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698