Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Side by Side Diff: net/quic/quic_crypto_server_stream_test.cc

Issue 2187463004: Add a new flag to require QUIC handshake confirmation, but only for versions before 33 FLAGS_quic_r… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@128425078
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/crypto/quic_crypto_server_config.cc ('k') | net/quic/quic_flags.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_crypto_server_stream.h" 5 #include "net/quic/quic_crypto_server_stream.h"
6 6
7 #include <map> 7 #include <map>
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 516 matching lines...) Expand 10 before | Expand all | Expand 10 after
527 Initialize(); 527 Initialize();
528 528
529 CompleteCryptoHandshake(); 529 CompleteCryptoHandshake();
530 EXPECT_EQ( 530 EXPECT_EQ(
531 0u, server_stream()->crypto_negotiated_params().token_binding_key_param); 531 0u, server_stream()->crypto_negotiated_params().token_binding_key_param);
532 EXPECT_TRUE(server_stream()->encryption_established()); 532 EXPECT_TRUE(server_stream()->encryption_established());
533 EXPECT_TRUE(server_stream()->handshake_confirmed()); 533 EXPECT_TRUE(server_stream()->handshake_confirmed());
534 } 534 }
535 535
536 TEST_P(QuicCryptoServerStreamTest, CancelRPCBeforeVerificationCompletes) { 536 TEST_P(QuicCryptoServerStreamTest, CancelRPCBeforeVerificationCompletes) {
537 FLAGS_quic_require_handshake_confirmation_pre33 = false;
537 // Tests that the client can close the connection while the remote strike 538 // Tests that the client can close the connection while the remote strike
538 // register verification RPC is still pending. 539 // register verification RPC is still pending.
539 540
540 // Set version to QUIC_VERSION_32 as QUIC_VERSION_33 and later don't support 541 // Set version to QUIC_VERSION_32 as QUIC_VERSION_33 and later don't support
541 // asynchronous strike register RPCs. 542 // asynchronous strike register RPCs.
542 supported_versions_ = {QUIC_VERSION_32}; 543 supported_versions_ = {QUIC_VERSION_32};
543 Initialize(); 544 Initialize();
544 if (!AsyncStrikeRegisterVerification()) { 545 if (!AsyncStrikeRegisterVerification()) {
545 return; 546 return;
546 } 547 }
(...skipping 25 matching lines...) Expand all
572 QUIC_NO_ERROR, "", ConnectionCloseBehavior::SILENT_CLOSE); 573 QUIC_NO_ERROR, "", ConnectionCloseBehavior::SILENT_CLOSE);
573 574
574 // The outstanding nonce verification RPC now completes. 575 // The outstanding nonce verification RPC now completes.
575 strike_register_client_->RunPendingVerifications(); 576 strike_register_client_->RunPendingVerifications();
576 } 577 }
577 578
578 } // namespace 579 } // namespace
579 580
580 } // namespace test 581 } // namespace test
581 } // namespace net 582 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/crypto/quic_crypto_server_config.cc ('k') | net/quic/quic_flags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698