Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2187433006: RELOAD: Check if an implicit closure needs rebinding at compile time and adjust closure equality. (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

RELOAD: Check if an implicit closure needs rebinding at compile time and adjust closure equality. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/d37ea681f5d80a3ab150b709baaeb1fef7a12cae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -17 lines) Patch
M runtime/lib/function.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/vm/isolate_reload_test.cc View 7 chunks +52 lines, -12 lines 0 comments Download
M runtime/vm/parser.cc View 3 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 4 months ago (2016-07-27 23:42:51 UTC) #2
Cutch
lgtm
4 years, 4 months ago (2016-07-27 23:46:47 UTC) #3
rmacnak
4 years, 4 months ago (2016-07-27 23:51:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d37ea681f5d80a3ab150b709baaeb1fef7a12cae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698