Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2187433004: Don't use Ahem font in two tests to avoid flakiness (Closed)

Created:
4 years, 4 months ago by Xianzhu
Modified:
4 years, 4 months ago
Reviewers:
eae
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use Ahem font in two tests to avoid flakiness Ahem font is flaky on Mac and Windows because of bug 392046 and bug 331583, so we should avoid it if possible. BUG=378610 NOTRY=true Committed: https://crrev.com/17172f620e9c4e89c1981de9c17598cc145ff170 Cr-Commit-Position: refs/heads/master@{#408040}

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/inline-focus.html View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/focus-ring-text.svg View 1 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/focus-ring-text-expected.html View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Xianzhu
4 years, 4 months ago (2016-07-26 22:55:58 UTC) #4
eae
LGTM
4 years, 4 months ago (2016-07-26 23:28:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187433004/20001
4 years, 4 months ago (2016-07-27 04:27:09 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 04:32:08 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 04:33:52 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/17172f620e9c4e89c1981de9c17598cc145ff170
Cr-Commit-Position: refs/heads/master@{#408040}

Powered by Google App Engine
This is Rietveld 408576698