Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2187433002: [gn] Switch off java targets for v8 standalone (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Switch off java targets for v8 standalone BUG=chromium:629806 Committed: https://crrev.com/a06f63a2d3661e1d1d27adadf8a054223418a165 Cr-Commit-Position: refs/heads/master@{#38054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build_overrides/build.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Michael Achenbach
PTAL This will switch off using https://cs.chromium.org/chromium/src/v8/BUILD.gn?q=v8_external_startup_data_assets&sq=package:chromium&l=533&dr=C Guess we don't need that in the standalone ...
4 years, 4 months ago (2016-07-26 10:21:02 UTC) #3
jbudorick
not really familiar with v8 standalone, but the change itself lgtm
4 years, 4 months ago (2016-07-26 14:07:04 UTC) #8
Michael Achenbach
On 2016/07/26 14:07:04, jbudorick wrote: > not really familiar with v8 standalone, but the change ...
4 years, 4 months ago (2016-07-26 14:09:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187433002/1
4 years, 4 months ago (2016-07-26 14:11:08 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 14:13:25 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 14:15:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a06f63a2d3661e1d1d27adadf8a054223418a165
Cr-Commit-Position: refs/heads/master@{#38054}

Powered by Google App Engine
This is Rietveld 408576698