DBC: Implement coverage by adding missing count increments to unoptimized static and instance calls.

DBC: Implement coverage by adding missing count increments to unoptimized static and instance calls.

These counts also factor into inlining decisions.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/f6a320b973be0e5f622e6f4886a7afc0b08eedda

[rmacnak, 2016-07-28 21:52:34]

rmacnak@google.com changed reviewers:
+ zra@google.com

[zra, 2016-07-28 22:03:53]

https://codereview.chromium.org/2187423002/diff/60001/runtime/vm/simulator_db...
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2187423002/diff/60001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:620:
SimulatorHelpers::IncrementICUsageCount(cache->data(), i, kCheckedArgs);
Should this be incremented after handling an inline cache miss? Either way,
maybe just remember 'i' here, and do this in an else-if after the if (!found)
below, just to pull this out of the loop.

https://codereview.chromium.org/2187423002/diff/60001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:663: if (!optimized) {
ditto.

[rmacnak, 2016-07-28 22:22:04]

https://codereview.chromium.org/2187423002/diff/60001/runtime/vm/simulator_db...
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2187423002/diff/60001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:620:
SimulatorHelpers::IncrementICUsageCount(cache->data(), i, kCheckedArgs);
On 2016/07/28 22:03:53, zra wrote:
> Should this be incremented after handling an inline cache miss? 

No, the runtime call that adds the new entry gives it an initial count of 1.

Either way,
> maybe just remember 'i' here, and do this in an else-if after the if (!found)
> below, just to pull this out of the loop.

Done

[zra, 2016-07-28 22:25:56]

lgtm

[rmacnak, 2016-07-28 23:43:51]

Description was changed from

==========
DBC: Implement coverage by adding missing count increments to unoptimized static
and instance calls.

These counts also factor into inlining decisions.
==========

to

==========
DBC: Implement coverage by adding missing count increments to unoptimized static
and instance calls.

These counts also factor into inlining decisions.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f6a320b973be0e5f622e6f4886a7afc0b08eedda
==========

[rmacnak, 2016-07-28 23:43:52]

Committed patchset #5 (id:80001) manually as
f6a320b973be0e5f622e6f4886a7afc0b08eedda (presubmit successful).

[rmacnak, 2016-07-29 16:59:41]

On 2016/07/28 23:43:52, rmacnak wrote:
> Committed patchset #5 (id:80001) manually as
> f6a320b973be0e5f622e6f4886a7afc0b08eedda (presubmit successful).

Golem results

Richards (ARMv7HF) 0.354%
ParticleSystemUpdate (ARMv7HF) 1.569%
FluidMotion (ARMv7HF) 3.320%
StarryStrings (ARMv7HF) 4.317%
Tracer (ARMv7HF) 6.665%
DeltaBlueClosures (ARMv7HF) 11.304%
DeltaBlue (ARMv7HF) 15.879%
ParticleSystemPaint (ARMv7HF) 18.704%

[zra, 2016-07-29 17:11:17]

On 2016/07/29 16:59:41, rmacnak wrote:
> On 2016/07/28 23:43:52, rmacnak wrote:
> > Committed patchset #5 (id:80001) manually as
> > f6a320b973be0e5f622e6f4886a7afc0b08eedda (presubmit successful).
> 
> Golem results
> 
> Richards (ARMv7HF) 0.354%
> ParticleSystemUpdate (ARMv7HF) 1.569%
> FluidMotion (ARMv7HF) 3.320%
> StarryStrings (ARMv7HF) 4.317%
> Tracer (ARMv7HF) 6.665%
> DeltaBlueClosures (ARMv7HF) 11.304%
> DeltaBlue (ARMv7HF) 15.879%
> ParticleSystemPaint (ARMv7HF) 18.704%

Nice!