cc : Use screen space transform for computing translation

cc : Use screen space transform computing translation

Since flattenning won't effect the result,
TransformTree::ComputeTranslation can use screen space transform instead
of calling ComputeTransforms.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/b7a8f7678a999ba33e509e918e8e339956e3d150
Cr-Commit-Position: refs/heads/master@{#408462}

[jaydasika, 2016-07-28 19:00:16]

Description was changed from

==========
cc : Use screen space transform computing translation

Since flattenning won't effect the result,
TransformTree::ComputeTranslation can use screen space transform instead
of calling ComputeTransforms.

BUG=622372
==========

to

==========
cc : Use screen space transform computing translation

Since flattenning won't effect the result,
TransformTree::ComputeTranslation can use screen space transform instead
of calling ComputeTransforms.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-07-28 19:01:24]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[jaydasika, 2016-07-28 19:01:54]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-07-28 19:01:55]

PTAL

[jaydasika, 2016-07-28 19:02:05]

Description was changed from

==========
cc : Use screen space transform computing translation

Since flattenning won't effect the result,
TransformTree::ComputeTranslation can use screen space transform instead
of calling ComputeTransforms.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Use screen space transform computing translation

Since flattenning won't effect the result,
TransformTree::ComputeTranslation can use screen space transform instead
of calling ComputeTransforms.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-07-28 19:02:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2016-07-28 19:06:14]

lgtm

https://codereview.chromium.org/2187403002/diff/20001/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/2187403002/diff/20001/cc/trees/property_tree....
cc/trees/property_tree.cc:164: // Since the transform between source and
destination is atmost translation,
nit: "at most" (missing space)

https://codereview.chromium.org/2187403002/diff/20001/cc/trees/property_tree....
cc/trees/property_tree.cc:165: // flattenning will not effect the result and we
can use the screen space
s/effect/affect

[jaydasika, 2016-07-28 19:12:53]

https://codereview.chromium.org/2187403002/diff/20001/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/2187403002/diff/20001/cc/trees/property_tree....
cc/trees/property_tree.cc:164: // Since the transform between source and
destination is atmost translation,
On 2016/07/28 19:06:14, ajuma wrote:
> nit: "at most" (missing space)

Done.

https://codereview.chromium.org/2187403002/diff/20001/cc/trees/property_tree....
cc/trees/property_tree.cc:165: // flattenning will not effect the result and we
can use the screen space
On 2016/07/28 19:06:14, ajuma wrote:
> s/effect/affect

Done.

[jaydasika, 2016-07-28 19:12:59]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-07-28 19:13:00]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2187403002/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2016-07-28 19:13:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 20:23:14]

Description was changed from

==========
cc : Use screen space transform computing translation

Since flattenning won't effect the result,
TransformTree::ComputeTranslation can use screen space transform instead
of calling ComputeTransforms.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Use screen space transform computing translation

Since flattenning won't effect the result,
TransformTree::ComputeTranslation can use screen space transform instead
of calling ComputeTransforms.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-07-28 20:23:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-28 20:26:06]

Description was changed from

==========
cc : Use screen space transform computing translation

Since flattenning won't effect the result,
TransformTree::ComputeTranslation can use screen space transform instead
of calling ComputeTransforms.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Use screen space transform computing translation

Since flattenning won't effect the result,
TransformTree::ComputeTranslation can use screen space transform instead
of calling ComputeTransforms.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/b7a8f7678a999ba33e509e918e8e339956e3d150
Cr-Commit-Position: refs/heads/master@{#408462}
==========

[commit-bot: I haz the power, 2016-07-28 20:26:07]

Patchset 3 (id:??) landed as
https://crrev.com/b7a8f7678a999ba33e509e918e8e339956e3d150
Cr-Commit-Position: refs/heads/master@{#408462}

[tapted, 2016-07-29 00:42:42]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2188413002/ by tapted@chromium.org.

The reason for reverting is: Causes
ExtensionCrxInstallerTest.InstallDelayedUntilNextUpdate to fail on linux debug

links:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...
https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.c...

errors like

ExtensionCrxInstallerTest.InstallDelayedUntilNextUpdate (run #1):
[ RUN      ] ExtensionCrxInstallerTest.InstallDelayedUntilNextUpdate
[1:1:0728/152609:FATAL:property_tree.cc(181)] Check failed:
transform->IsApproximatelyIdentityOrTranslation(SkDoubleToMScalar(1e-4)).
..
#2 0x7f99d9f73a0d cc::TransformTree::ComputeTranslation()
#3 0x7f99d9f74189 cc::TransformTree::UpdateLocalTransform()
#4 0x7f99d9f73ece cc::TransformTree::UpdateTransforms()
#5 0x7f99d9fa0ce0 cc::(anonymous namespace)::AddTransformNodeIfNeeded<>()
#6 0x7f99d9f9e98d cc::(anonymous namespace)::BuildPropertyTreesInternal<>().