Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2187393002: Flip two Mac ASAN straggler builders to GN and fix mb audit. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip two Mac ASAN straggler builders to GN and fix mb audit. The addition of the internal.client.kitchensync builder broke mb audit (which can't audit internal builders), so this skips that, and toggles two builders that were supposed to be flipped to GN but I mistyped things :). TBR=rsesek@chromium.org BUG=618468 Committed: https://crrev.com/6b6e0b85322994b4e785f9bcbe3e6f7deda24b2e Cr-Commit-Position: refs/heads/master@{#408485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M tools/mb/mb.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/mb/mb_config.pyl View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dirk Pranke
4 years, 4 months ago (2016-07-28 20:28:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187393002/1
4 years, 4 months ago (2016-07-28 20:32:20 UTC) #3
Robert Sesek
lgtm
4 years, 4 months ago (2016-07-28 20:32:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 21:32:50 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 21:35:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b6e0b85322994b4e785f9bcbe3e6f7deda24b2e
Cr-Commit-Position: refs/heads/master@{#408485}

Powered by Google App Engine
This is Rietveld 408576698