Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 2187353003: headless: Support --use-gl in headless shell (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
Reviewers:
Eric Seckler, altimin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Support --use-gl in headless shell This patch adds support for the --use-gl command line flag in headless shell and makes sure we build the default osmesa implementation. BUG=617551 Committed: https://crrev.com/ebfd868404015fb9cb48e99484c5521b93286f62 Cr-Commit-Position: refs/heads/master@{#408441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M headless/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M headless/app/headless_shell.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M headless/app/headless_shell_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M headless/app/headless_shell_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Sami
4 years, 4 months ago (2016-07-28 17:38:23 UTC) #3
Sami
+Eric FYI
4 years, 4 months ago (2016-07-28 17:39:07 UTC) #5
altimin
lgtm
4 years, 4 months ago (2016-07-28 17:44:40 UTC) #6
Eric Seckler
lgtm
4 years, 4 months ago (2016-07-28 17:47:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187353003/1
4 years, 4 months ago (2016-07-28 17:59:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 18:44:19 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 18:45:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebfd868404015fb9cb48e99484c5521b93286f62
Cr-Commit-Position: refs/heads/master@{#408441}

Powered by Google App Engine
This is Rietveld 408576698