Generating autocomplete results with and without word breaks in the Omnibox.

components/omnibox/browser/history_quick_provider_unittest.cc

Index: components/omnibox/browser/history_quick_provider_unittest.cc
diff --git a/components/omnibox/browser/history_quick_provider_unittest.cc b/components/omnibox/browser/history_quick_provider_unittest.cc
index 816f298d0d1352fd84de3634709af799530b3ac7..ec9a904003ca5ff72b168e8c470e30c1652fd7f7 100644
--- a/components/omnibox/browser/history_quick_provider_unittest.cc
+++ b/components/omnibox/browser/history_quick_provider_unittest.cc
@@ -496,6 +496,35 @@ TEST_F(HistoryQuickProviderTest, SingleMatchWithCursor) {
                     base::string16());
 }
 
+TEST_F(HistoryQuickProviderTest, MatchWithAndWithoutCursorWordBreak) {

[Mark P, 2016/08/22 18:24:11]

I'm surprised this test passes as-is, as it doesn't look like you added the
twitter URL to the list of pages the URL has visited.  (See TestURLInfo above.) 
Did you actually run this test?  (build components_unittests, run it with
--gtest_filter=HistoryQuick*.*)

Also, in addition to making sure this test passes, please double-check that this
new test fails without your change.  (One easy way to check is to make a copy of
the .h and .cc you've changed, remove those changes, build and run the test to
see if it passes or fails, and then replace the .h and .cc with your copied
files to restore your changes.)

[Lavar Askew, 2016/08/23 20:38:19]

Can't I just start up the latest release instance of Chrome (on any machine),
enter the twitter URL and go through my test sequence of "funtimes" then
"fungoodtimes"?  When I do this it fails.  When I run an instance of Chrome with
my new code it works....Done.

+  std::vector<std::string> expected_urls;
+  expected_urls.push_back("https://twitter.com/fungoodtimes");
+  // With cursor after "good", we should retrieve the desired result but it
+  // should not be allowed to be the default match.
+  RunTestWithCursor(ASCIIToUTF16("fungoodtimes"), 7, false, expected_urls,
+                    false, ASCIIToUTF16("twitter.com/fungoodtimes"),
+                    base::string16());
+}
+
+// Runs an autocomplete query on |text| and checks to see that the returned

[Mark P, 2016/08/22 18:24:11]

This function declaration and the one below shouldn't be here.  Did you
accidentally copy-and-paste them here?

[Lavar Askew, 2016/08/23 20:38:19]

Deleted those lines....Done.

+// results' destination URLs match those provided. |expected_urls| does not
+// need to be in sorted order.
+void RunTest(const base::string16 text,
+             bool prevent_inline_autocomplete,
+             std::vector<std::string> expected_urls,
+             bool can_inline_top_result,
+             base::string16 expected_fill_into_edit,
+             base::string16 autocompletion);
+
+// As above, simply with a cursor position specified.
+void RunTestWithCursor(const base::string16 text,
+                       const size_t cursor_position,
+                       bool prevent_inline_autocomplete,
+                       std::vector<std::string> expected_urls,
+                       bool can_inline_top_result,
+                       base::string16 expected_fill_into_edit,
+                       base::string16 autocompletion);
+
 TEST_F(HistoryQuickProviderTest, WordBoundariesWithPunctuationMatch) {
   std::vector<std::string> expected_urls;
   expected_urls.push_back("http://popularsitewithpathonly.com/moo");