Fix warning about always_inline attribute in libjpeg_turbo.

Fix warning about always_inline attribute in libjpeg_turbo.

GCC 4.7/4.8 warns when __attribute__((always_inline)) is used without a
normal 'inline' keyword. Pull an equivalent of upstream r1188 to avoid
this warning.

R=rmcilroy@chromium.org, phajdan.jr@chromium.org

Committed: 261103

[rmcilroy, 2014-03-31 07:50:59]

On 2014/03/31 07:45:45, tsniatowski wrote:

Could you update README.chromium to mention you've cherry-picked this change
please.

[tsniatowski, 2014-03-31 07:58:12]

On 2014/03/31 07:50:59, rmcilroy wrote:
> Could you update README.chromium to mention you've cherry-picked this change
> please.

Sure, should it be in the "Also, we applied the following changes which are not
merged to upstream:" section or in a new "backported from trunk:" section?

[rmcilroy, 2014-03-31 09:17:43]

On 2014/03/31 07:58:12, tsniatowski wrote:
> On 2014/03/31 07:50:59, rmcilroy wrote:
> > Could you update README.chromium to mention you've cherry-picked this change
> > please.
> 
> Sure, should it be in the "Also, we applied the following changes which are
not
> merged to upstream:" section or in a new "backported from trunk:" section?

I don't see a "Also, we applied the following changes which are not merged to
upstream:" section in README.chromium.  I would just have a put a new bullet in
the description sections as below: 

* A partial copy of libjpeg-turbo 1.2.80 (r856);
* Revisions r1188 cherry-picked from upstream;
...

[rmcilroy, 2014-03-31 16:12:32]

On 2014/03/31 09:17:43, rmcilroy wrote:
> On 2014/03/31 07:58:12, tsniatowski wrote:
> > On 2014/03/31 07:50:59, rmcilroy wrote:
> > > Could you update README.chromium to mention you've cherry-picked this
change
> > > please.
> > 
> > Sure, should it be in the "Also, we applied the following changes which are
> not
> > merged to upstream:" section or in a new "backported from trunk:" section?
> 
> I don't see a "Also, we applied the following changes which are not merged to
> upstream:" section in README.chromium.  I would just have a put a new bullet
in
> the description sections as below: 
> 
> * A partial copy of libjpeg-turbo 1.2.80 (r856);
> * Revisions r1188 cherry-picked from upstream;
> ...

lgtm

[tsniatowski, 2014-03-31 18:49:24]

The CQ bit was checked by tsniatowski@opera.com

[commit-bot: I haz the power, 2014-03-31 18:50:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-31 18:50:08]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[tsniatowski, 2014-04-01 06:47:05]

On 2014/03/31 18:50:08, I haz the power (commit-bot) wrote:
> Commit queue rejected this change because it did not recognize the base URL.
> Please commit your change manually.

OK, so it looks like (a) this exact change was submitted before as
https://codereview.chromium.org/202683008/ but that was prior to the upstream's
acceptance, and (b) I don't know how to commit this. rmcilroy, can you help with
the latter?

[rmcilroy, 2014-04-01 10:56:48]

On 2014/04/01 06:47:05, tsniatowski wrote:
> On 2014/03/31 18:50:08, I haz the power (commit-bot) wrote:
> > Commit queue rejected this change because it did not recognize the base URL.
> > Please commit your change manually.
> 
> OK, so it looks like (a) this exact change was submitted before as
> https://codereview.chromium.org/202683008/ but that was prior to the
upstream's
> acceptance, and (b) I don't know how to commit this. rmcilroy, can you help
with
> the latter?

So https://codereview.chromium.org/202683008/ was never committed, just closed,
so you will need to commit this CL as well.  You can find the instructions for
setting up the repo correctly here:
  http://www.chromium.org/developers/how-tos/get-the-code
Under the heading "Committing from repositories other than the main Chromium
repository".  You will need to follow the instructions for "URL starts with 
http://src.chromium.org/svn".  Let me know if you have issues and I'll see if I
can submit it instead.

I can do the roll once you've done this.

[tsniatowski, 2014-04-01 12:59:48]

On 2014/04/01 10:56:48, rmcilroy wrote:
> On 2014/04/01 06:47:05, tsniatowski wrote:
> > On 2014/03/31 18:50:08, I haz the power (commit-bot) wrote:
> > > Commit queue rejected this change because it did not recognize the base
URL.
> > > Please commit your change manually.
> > 
> > OK, so it looks like (a) this exact change was submitted before as
> > https://codereview.chromium.org/202683008/ but that was prior to the
> upstream's
> > acceptance, and (b) I don't know how to commit this. rmcilroy, can you help
> with
> > the latter?
> 
> So https://codereview.chromium.org/202683008/ was never committed, just
closed,
> so you will need to commit this CL as well.  You can find the instructions for
> setting up the repo correctly here:
>   http://www.chromium.org/developers/how-tos/get-the-code
> Under the heading "Committing from repositories other than the main Chromium
> repository".  You will need to follow the instructions for "URL starts with 
> http://src.chromium.org/svn%22.  Let me know if you have issues and I'll see
if I
> can submit it instead.
> 
> I can do the roll once you've done this.

I believe I don't have committer access. The svn-password service provides me
with a svn password that looks readonly: my "git cl dcommit" is rejected but I
can svn ls the "push-url" as described in the get-the-code guide.

[rmcilroy, 2014-04-02 09:57:34]

On 2014/04/01 12:59:48, tsniatowski wrote:
> On 2014/04/01 10:56:48, rmcilroy wrote:
> > On 2014/04/01 06:47:05, tsniatowski wrote:
> > > On 2014/03/31 18:50:08, I haz the power (commit-bot) wrote:
> > > > Commit queue rejected this change because it did not recognize the base
> URL.
> > > > Please commit your change manually.
> > > 
> > > OK, so it looks like (a) this exact change was submitted before as
> > > https://codereview.chromium.org/202683008/ but that was prior to the
> > upstream's
> > > acceptance, and (b) I don't know how to commit this. rmcilroy, can you
help
> > with
> > > the latter?
> > 
> > So https://codereview.chromium.org/202683008/ was never committed, just
> closed,
> > so you will need to commit this CL as well.  You can find the instructions
for
> > setting up the repo correctly here:
> >   http://www.chromium.org/developers/how-tos/get-the-code
> > Under the heading "Committing from repositories other than the main Chromium
> > repository".  You will need to follow the instructions for "URL starts with 
> > http://src.chromium.org/svn%22.  Let me know if you have issues and I'll see
> if I
> > can submit it instead.
> > 
> > I can do the roll once you've done this.
> 
> I believe I don't have committer access. The svn-password service provides me
> with a svn password that looks readonly: my "git cl dcommit" is rejected but I
> can svn ls the "push-url" as described in the get-the-code guide.

I don't think this will work - I will land the patch for you.

[rmcilroy, 2014-04-02 09:58:35]

Committed patchset #3 manually as r261103 (presubmit successful).

[tsniatowski, 2014-04-02 10:03:17]

On 2014/04/02 09:58:35, rmcilroy wrote:
> Committed patchset #3 manually as r261103 (presubmit successful).

Thanks!