Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2187263002: Revert "[inspector] add inspector protocol parser test build target for GYP." (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[inspector] add inspector protocol parser test build target for GYP." Breaks chromium win. This also includes: Revert "[gn] Add missing deps to inspector_protocol_parser_test" Revert "Fix gitignores after moving inspector_protocol" NOTRY=true BUG=chromium:580337 TBR=yangguo@chromium.org, jochen@chromium.org, pfeldman@chromium.org Committed: https://crrev.com/6b23ce3061b91456b3e531d02d18c59279603f93 Cr-Commit-Position: refs/heads/master@{#38128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1271 lines) Patch
M .gitignore View 2 chunks +1 line, -6 lines 0 comments Download
M DEPS View 1 chunk +2 lines, -6 lines 0 comments Download
M gypfiles/all.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M gypfiles/standalone.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D src/inspector/BUILD.gn View 1 chunk +0 lines, -91 lines 0 comments Download
D src/inspector/inspector.gyp View 1 chunk +0 lines, -100 lines 0 comments Download
D src/inspector/js_protocol.json View 1 chunk +0 lines, -990 lines 0 comments Download
M test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D test/inspector_protocol_parser_test/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D test/inspector_protocol_parser_test/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D test/inspector_protocol_parser_test/RunTests.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
D test/inspector_protocol_parser_test/inspector_protocol_parser_test.gyp View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Michael Achenbach
TBR Broke: https://build.chromium.org/p/chromium/builders/Win/builds/45681 Cherry picking the manifest fix didn't help: https://build.chromium.org/p/chromium/builders/Win/builds/45683
4 years, 4 months ago (2016-07-28 10:17:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187263002/1
4 years, 4 months ago (2016-07-28 10:17:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 10:19:06 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 10:21:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b23ce3061b91456b3e531d02d18c59279603f93
Cr-Commit-Position: refs/heads/master@{#38128}

Powered by Google App Engine
This is Rietveld 408576698