components/autofill/content/renderer/password_autofill_agent.h - Issue 2187253002: [Password Manager] Change signature of PasswordAutofillAgent.FillSuggestion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 2187253002: [Password Manager] Change signature of PasswordAutofillAgent.FillSuggestion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_autofill_agent.h

diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h

index b0da2dedd23a482c3ab393dff449d35447f98467..90b48fd11a5b596f9f69875b1e887ab03f8a3ddd 100644

--- a/components/autofill/content/renderer/password_autofill_agent.h

+++ b/components/autofill/content/renderer/password_autofill_agent.h

@@ -53,9 +53,9 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {

// Fills the username and password fields of this form with the given values.

// Returns true if the fields were filled, false otherwise.

- bool FillSuggestion(const blink::WebFormControlElement& node,

- const blink::WebString& username,

- const blink::WebString& password);

+ bool FillSuggestion(const blink::WebFormControlElement& control_element,

+ const base::string16& username,

+ const base::string16& password);

// Previews the username and password fields of this form with the given

// values. Returns true if the fields were previewed, false otherwise.