[Password Manager] Change signature of PasswordAutofillAgent.FillSuggestion

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
@@ skipping 709 matching lines @@
       web_input_to_password_info_[iter->second].password_was_edited_last = true;
       // Note that the suggested value of |mutable_element| was reset when its
       // value changed.
       mutable_element.setAutofilled(false);
     }
   }
 }
 
 bool PasswordAutofillAgent::FillSuggestion(
     const blink::WebFormControlElement& control_element,
-    const blink::WebString& username,
-    const blink::WebString& password) {
+    const base::string16& username,
+    const base::string16& password) {
   // The element in context of the suggestion popup.
   const blink::WebInputElement* element = toWebInputElement(&control_element);
   if (!element)
     return false;
 
   blink::WebInputElement username_element;
   blink::WebInputElement password_element;
   PasswordInfo* password_info;
 
   if (!FindPasswordInfoForElement(*element, &username_element,
                                   &password_element, &password_info) ||
       (!username_element.isNull() &&
        !IsElementAutocompletable(username_element)) ||
       !IsElementAutocompletable(password_element)) {
     return false;
   }
 
   password_info->password_was_edited_last = false;
   if (element->isPasswordField()) {
     password_info->password_field_suggestion_was_accepted = true;
     password_info->password_field = password_element;
   } else if (!username_element.isNull()) {
-    username_element.setValue(username, true);
+    username_element.setValue(blink::WebString(username), true);
     username_element.setAutofilled(true);
-    const base::string16 username_value = username;
-    UpdateFieldValueAndPropertiesMaskMap(username_element, &username_value,
+    UpdateFieldValueAndPropertiesMaskMap(username_element, &username,
                                          FieldPropertiesFlags::AUTOFILLED,
                                          &field_value_and_properties_map_);
   }
 
-  password_element.setValue(password, true);
+  password_element.setValue(blink::WebString(password), true);
   password_element.setAutofilled(true);
-  const base::string16 password_value = password;
-  UpdateFieldValueAndPropertiesMaskMap(password_element, &password_value,
+  UpdateFieldValueAndPropertiesMaskMap(password_element, &password,
                                        FieldPropertiesFlags::AUTOFILLED,
                                        &field_value_and_properties_map_);
 
   blink::WebInputElement mutable_filled_element = *element;
   mutable_filled_element.setSelectionRange(element->value().length(),
                                            element->value().length());
 
   return true;
 }
 
@@ skipping 756 matching lines @@
          !(provisionally_saved_form_->password_value.empty() &&
          provisionally_saved_form_->new_password_value.empty());
 }
 
 const mojom::AutofillDriverPtr& PasswordAutofillAgent::GetAutofillDriver() {
   DCHECK(autofill_agent_);
   return autofill_agent_->GetAutofillDriver();
 }
 
 }  // namespace autofill