Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h

Issue 2187233002: Add ContentSuggestionsCategoryFactory; Store categories as ints (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h
diff --git a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h
index 651342d74d466d188bc2810e07be00f892d4cd60..5d2c5fafdea6f83f50b45e3e4b0e1794b528997d 100644
--- a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h
+++ b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h
@@ -12,6 +12,7 @@
#include "components/keyed_service/core/keyed_service.h"
#include "components/ntp_snippets/content_suggestion.h"
#include "components/ntp_snippets/content_suggestions_category.h"
+#include "components/ntp_snippets/content_suggestions_category_factory.h"
#include "components/ntp_snippets/content_suggestions_category_status.h"
#include "components/ntp_snippets/content_suggestions_provider.h"
#include "components/offline_pages/offline_page_model.h"
@@ -32,6 +33,7 @@ class OfflinePageSuggestionsProvider
public offline_pages::OfflinePageModel::Observer {
public:
OfflinePageSuggestionsProvider(
+ ContentSuggestionsCategoryFactory* category_factory,
offline_pages::OfflinePageModel* offline_page_model);
~OfflinePageSuggestionsProvider() override;
@@ -40,6 +42,7 @@ class OfflinePageSuggestionsProvider
private:
// ContentSuggestionsProvider implementation.
+ std::vector<ContentSuggestionsCategory> provided_categories() override;
void SetObserver(ContentSuggestionsProvider::Observer* observer) override;
ContentSuggestionsCategoryStatus GetCategoryStatus(
ContentSuggestionsCategory category) override;
@@ -71,6 +74,8 @@ class OfflinePageSuggestionsProvider
offline_pages::OfflinePageModel* offline_page_model_;
+ ContentSuggestionsCategory provided_category_;
Marc Treib 2016/07/28 11:41:46 const?
Philipp Keck 2016/07/28 13:50:55 Done.
+
DISALLOW_COPY_AND_ASSIGN(OfflinePageSuggestionsProvider);
};

Powered by Google App Engine
This is Rietveld 408576698