Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: chrome/browser/android/ntp/ntp_snippets_bridge.h

Issue 2187233002: Add ContentSuggestionsCategoryFactory; Store categories as ints (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_NTP_NTP_SNIPPETS_BRIDGE_H_ 5 #ifndef CHROME_BROWSER_ANDROID_NTP_NTP_SNIPPETS_BRIDGE_H_
6 #define CHROME_BROWSER_ANDROID_NTP_NTP_SNIPPETS_BRIDGE_H_ 6 #define CHROME_BROWSER_ANDROID_NTP_NTP_SNIPPETS_BRIDGE_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/scoped_java_ref.h" 10 #include "base/android/scoped_java_ref.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 const gfx::Image& image); 71 const gfx::Image& image);
72 72
73 ntp_snippets::ContentSuggestionsService* content_suggestions_service_; 73 ntp_snippets::ContentSuggestionsService* content_suggestions_service_;
74 history::HistoryService* history_service_; 74 history::HistoryService* history_service_;
75 base::CancelableTaskTracker tracker_; 75 base::CancelableTaskTracker tracker_;
76 76
77 ScopedObserver<ntp_snippets::ContentSuggestionsService, 77 ScopedObserver<ntp_snippets::ContentSuggestionsService,
78 ntp_snippets::ContentSuggestionsService::Observer> 78 ntp_snippets::ContentSuggestionsService::Observer>
79 content_suggestions_service_observer_; 79 content_suggestions_service_observer_;
80 80
81 ntp_snippets::ContentSuggestionsCategoryFactory* category_factory_;
Marc Treib 2016/07/28 11:41:45 Any particular reason for storing this separately,
Philipp Keck 2016/07/28 13:50:53 Done.
82
81 // Used to notify the Java side when new snippets have been fetched. 83 // Used to notify the Java side when new snippets have been fetched.
82 base::android::ScopedJavaGlobalRef<jobject> observer_; 84 base::android::ScopedJavaGlobalRef<jobject> observer_;
83 85
84 base::WeakPtrFactory<NTPSnippetsBridge> weak_ptr_factory_; 86 base::WeakPtrFactory<NTPSnippetsBridge> weak_ptr_factory_;
85 87
86 DISALLOW_COPY_AND_ASSIGN(NTPSnippetsBridge); 88 DISALLOW_COPY_AND_ASSIGN(NTPSnippetsBridge);
87 }; 89 };
88 90
89 #endif // CHROME_BROWSER_ANDROID_NTP_NTP_SNIPPETS_BRIDGE_H_ 91 #endif // CHROME_BROWSER_ANDROID_NTP_NTP_SNIPPETS_BRIDGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698