Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 218723002: Disable ChromeNotifierServiceTest.SetAddedAppIdsTest on GTK. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
Reviewers:
Pete Williamson
CC:
chromium-reviews
Visibility:
Public.

Description

Disable ChromeNotifierServiceTest.SetAddedAppIdsTest on GTK. It's failing like so: [ RUN ] ChromeNotifierServiceTest.SetAddedAppIdsTest ../../chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc:712: Failure Value of: notification_manager()->added_notifications() Actual: 1 Expected: static_cast<size_t>(2) Which is: 2 [ FAILED ] ChromeNotifierServiceTest.SetAddedAppIdsTest (37 ms) TBR=petewil@chromium.org BUG=358031 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
Committed patchset #1 manually as r260469 (presubmit successful).
6 years, 8 months ago (2014-03-30 20:57:29 UTC) #1
Pete Williamson
6 years, 8 months ago (2014-03-31 21:28:25 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698