Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2187103002: services/ui: Remove unused connector argument (Closed)

Created:
4 years, 4 months ago by Peng
Modified:
4 years, 4 months ago
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, tfarina, jam, darin-cc_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

services/ui: Remove unused connector argument BUG=630893 Committed: https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225 Cr-Commit-Position: refs/heads/master@{#408230}

Patch Set 1 #

Patch Set 2 : Fix build errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -91 lines) Patch
M ash/mus/bridge/wm_root_window_controller_mus.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/mus/non_client_frame_controller.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ash/touch_hud/mus/touch_hud_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_mus.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 2 chunks +1 line, -4 lines 0 comments Download
M mash/login/login.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/screenlock.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/view_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M services/ui/demo/mus_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/public/cpp/bitmap_uploader.h View 2 chunks +1 line, -5 lines 0 comments Download
M services/ui/public/cpp/context_provider.h View 2 chunks +1 line, -2 lines 0 comments Download
M services/ui/public/cpp/gles2_context.h View 2 chunks +2 lines, -8 lines 0 comments Download
M services/ui/public/cpp/lib/bitmap_uploader.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M services/ui/public/cpp/lib/context_provider.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M services/ui/public/cpp/lib/gles2_context.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M ui/views/mus/native_widget_mus.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ui/views/mus/surface_binding.h View 2 chunks +1 line, -7 lines 0 comments Download
M ui/views/mus/surface_binding.cc View 5 chunks +8 lines, -17 lines 0 comments Download
M ui/views/mus/surface_context_factory.h View 2 chunks +1 line, -6 lines 0 comments Download
M ui/views/mus/surface_context_factory.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
Peng
PTAL. Thanks.
4 years, 4 months ago (2016-07-27 19:34:07 UTC) #4
sadrul
lgtm
4 years, 4 months ago (2016-07-27 19:55:19 UTC) #7
Peng
ben@chromium.org: Please review changes in services/navigation/view_impl.cc & content/renderer/*
4 years, 4 months ago (2016-07-27 20:13:22 UTC) #11
Ben Goodger (Google)
nice! lgtm
4 years, 4 months ago (2016-07-27 20:16:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187103002/20001
4 years, 4 months ago (2016-07-27 20:38:22 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 20:42:01 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 20:43:33 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225
Cr-Commit-Position: refs/heads/master@{#408230}

Powered by Google App Engine
This is Rietveld 408576698