Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 2187043002: Revert of Flip DrMemory memory.fyi builders to GN. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
Reviewers:
brettw, Derek Bruening
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flip DrMemory memory.fyi builders to GN. (patchset #1 id:1 of https://codereview.chromium.org/2181843002/ ) Reason for revert: The builders appear to be all sorts of broken in GN; I don't even know how ninja is running at all, and the errors it is producing don't make any sense. Original issue's description: > Flip DrMemory memory.fyi builders to GN. > > R=bruening@chromium.org, brettw@chromium.org > BUG=605318 > > Committed: https://crrev.com/91224d8c9f54a8a6d9ed8fcffb43fde276ce4afa > Cr-Commit-Position: refs/heads/master@{#407940} TBR=bruening@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605318 Committed: https://crrev.com/df2307f88ab1411ce0dddfc92020d19345be47f5 Cr-Commit-Position: refs/heads/master@{#408166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M tools/mb/mb_config.pyl View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dirk Pranke
Created Revert of Flip DrMemory memory.fyi builders to GN.
4 years, 4 months ago (2016-07-27 17:23:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187043002/1
4 years, 4 months ago (2016-07-27 17:23:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 17:24:21 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 17:26:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df2307f88ab1411ce0dddfc92020d19345be47f5
Cr-Commit-Position: refs/heads/master@{#408166}

Powered by Google App Engine
This is Rietveld 408576698