Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: Source/devtools/front_end/EventListenersSidebarPane.js

Issue 218703002: DevTools: [wip] move Elements panel off WebInspector.domModel and single tree outline. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review comment addressed (and much more) Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 var remoteObject = this._runtimeModel.createRemoteObject(this.ev entListener.handler); 233 var remoteObject = this._runtimeModel.createRemoteObject(this.ev entListener.handler);
234 properties.push(new WebInspector.RemoteObjectProperty("handler", remoteObject)); 234 properties.push(new WebInspector.RemoteObjectProperty("handler", remoteObject));
235 } 235 }
236 properties.push(this._runtimeModel.createRemotePropertyFromPrimitive Value("listenerBody", this.eventListener.handlerBody)); 236 properties.push(this._runtimeModel.createRemotePropertyFromPrimitive Value("listenerBody", this.eventListener.handlerBody));
237 if (this.eventListener.sourceName) 237 if (this.eventListener.sourceName)
238 properties.push(this._runtimeModel.createRemotePropertyFromPrimi tiveValue("sourceName", this.eventListener.sourceName)); 238 properties.push(this._runtimeModel.createRemotePropertyFromPrimi tiveValue("sourceName", this.eventListener.sourceName));
239 properties.push(this._runtimeModel.createRemotePropertyFromPrimitive Value("lineNumber", this.eventListener.location.lineNumber + 1)); 239 properties.push(this._runtimeModel.createRemotePropertyFromPrimitive Value("lineNumber", this.eventListener.location.lineNumber + 1));
240 240
241 this.updateProperties(properties); 241 this.updateProperties(properties);
242 } 242 }
243 WebInspector.RemoteObject.resolveNode(this.eventListener.node, WebInspec tor.EventListenersSidebarPane._objectGroupName, updateWithNodeObject.bind(this)) ; 243 this.eventListener.node.resolveToObject(WebInspector.EventListenersSideb arPane._objectGroupName, updateWithNodeObject.bind(this));
244 }, 244 },
245 245
246 _setNodeTitle: function() 246 _setNodeTitle: function()
247 { 247 {
248 var node = this.eventListener.node; 248 var node = this.eventListener.node;
249 if (!node) 249 if (!node)
250 return; 250 return;
251 251
252 if (node.nodeType() === Node.DOCUMENT_NODE) { 252 if (node.nodeType() === Node.DOCUMENT_NODE) {
253 this.titleElement.textContent = "document"; 253 this.titleElement.textContent = "document";
(...skipping 17 matching lines...) Expand all
271 var url = this.eventListener.sourceName; 271 var url = this.eventListener.sourceName;
272 var lineNumber = this.eventListener.location.lineNumber; 272 var lineNumber = this.eventListener.location.lineNumber;
273 var columnNumber = 0; 273 var columnNumber = 0;
274 urlElement = linkifier.linkifyLocation(url, lineNumber, columnNumber ); 274 urlElement = linkifier.linkifyLocation(url, lineNumber, columnNumber );
275 } 275 }
276 this.subtitleElement.appendChild(urlElement); 276 this.subtitleElement.appendChild(urlElement);
277 }, 277 },
278 278
279 __proto__: WebInspector.ObjectPropertiesSection.prototype 279 __proto__: WebInspector.ObjectPropertiesSection.prototype
280 } 280 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/ElementsTreeOutline.js ('k') | Source/devtools/front_end/MetricsSidebarPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698