Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 218703002: DevTools: [wip] move Elements panel off WebInspector.domModel and single tree outline. (Closed)

Created:
6 years, 8 months ago by pfeldman
Modified:
6 years, 8 months ago
Reviewers:
apavlov, sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: [wip] move Elements panel off WebInspector.domModel and single tree outline. R=sergeyv@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170453

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Review comment addressed (and much more) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -281 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 1 3 chunks +8 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/inspector/inspect-element.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/inspector/console/shadow-element.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/edit-dom-actions.html View 1 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/edit-dom-actions-shadow.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/edit-dom-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/edit-trimmed-attribute-value.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/elements-img-tooltip.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/elements-inspect-iframe-from-different-domain.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/elements-panel-limited-children.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/elements-panel-selection-on-refresh.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/elements-panel-shadow-selection-on-refresh.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/expand-recursively.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/hide-shortcut.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/highlight-node-scaled.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/inline-style-title.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/inspect-deep-shadow-element.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/inspector/elements/inspect-mode-shadow-text.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/inspect-pointer-events-none.html View 1 2 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/inspector/elements/inspect-pseudo-element.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/move-node.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/resolve-alien-node.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/reveal-shadow-dom-node.html View 1 2 chunks +3 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/styles/force-pseudo-state.html View 1 4 chunks +9 lines, -9 lines 0 comments Download
M LayoutTests/inspector/elements/styles/pseudo-elements.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/style-update-during-selector-edit.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/styles-update-from-js.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/updates-during-dom-traversal.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/CSSStyleModel.js View 1 15 chunks +44 lines, -22 lines 0 comments Download
M Source/devtools/front_end/DOMModel.js View 1 34 chunks +90 lines, -32 lines 0 comments Download
M Source/devtools/front_end/DOMPresentationUtils.js View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ElementsPanel.js View 1 27 chunks +154 lines, -105 lines 0 comments Download
M Source/devtools/front_end/ElementsTreeOutline.js View 1 17 chunks +51 lines, -28 lines 0 comments Download
M Source/devtools/front_end/EventListenersSidebarPane.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/MetricsSidebarPane.js View 1 3 chunks +5 lines, -7 lines 0 comments Download
M Source/devtools/front_end/PropertiesSidebarPane.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/RemoteObject.js View 1 1 chunk +0 lines, -24 lines 0 comments Download
M Source/devtools/front_end/StylesSidebarPane.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pfeldman
6 years, 8 months ago (2014-03-30 18:05:33 UTC) #1
sergeyv
https://codereview.chromium.org/218703002/diff/20001/Source/devtools/front_end/CSSStyleModel.js File Source/devtools/front_end/CSSStyleModel.js (right): https://codereview.chromium.org/218703002/diff/20001/Source/devtools/front_end/CSSStyleModel.js#newcode591 Source/devtools/front_end/CSSStyleModel.js:591: CSSAgent.forcePseudoState(node.id, node.getUserProperty(WebInspector.CSSStyleModel.PseudoStatePropertyName) || []); we already have node.getUserProperty(WebInspector.CSSStyleModel.PseudoStatePropertyName) in ...
6 years, 8 months ago (2014-03-31 13:29:20 UTC) #2
pfeldman
https://codereview.chromium.org/218703002/diff/20001/Source/devtools/front_end/CSSStyleModel.js File Source/devtools/front_end/CSSStyleModel.js (right): https://codereview.chromium.org/218703002/diff/20001/Source/devtools/front_end/CSSStyleModel.js#newcode591 Source/devtools/front_end/CSSStyleModel.js:591: CSSAgent.forcePseudoState(node.id, node.getUserProperty(WebInspector.CSSStyleModel.PseudoStatePropertyName) || []); On 2014/03/31 13:29:20, sergeyv wrote: ...
6 years, 8 months ago (2014-03-31 13:45:49 UTC) #3
sergeyv
lgtm
6 years, 8 months ago (2014-03-31 13:49:53 UTC) #4
pfeldman
6 years, 8 months ago (2014-03-31 15:38:03 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r170453 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698