Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2186993003: Removing DownloadInfoTest (Closed)

Created:
4 years, 4 months ago by smaier
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer, agrieve
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing DownloadInfoTest It doesn't make sense to have DownloadInfoTest with upcoming ProGuard changes. It doesn't check any meaningful functionality (just that all setters correspond to getters, and that running all getters on a copied object all return the same values) and relies on getting the method's names via reflection, which is going to cause a lot of issues as ProGuard usage increases. BUG=620323 Committed: https://crrev.com/770c0cfd44f0a28c07c0f76ad6059f334d056b02 Cr-Commit-Position: refs/heads/master@{#408397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -224 lines) Patch
M chrome/android/java_sources.gni View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadInfoTest.java View 1 chunk +0 lines, -223 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
smaier
4 years, 4 months ago (2016-07-28 14:32:53 UTC) #3
agrieve
On 2016/07/28 14:32:53, smaier wrote: lgtm +bauerb for owners
4 years, 4 months ago (2016-07-28 15:00:41 UTC) #7
Bernhard Bauer
rubberstamp LGTM
4 years, 4 months ago (2016-07-28 15:05:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186993003/1
4 years, 4 months ago (2016-07-28 15:27:39 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 15:40:07 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 15:41:58 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/770c0cfd44f0a28c07c0f76ad6059f334d056b02
Cr-Commit-Position: refs/heads/master@{#408397}

Powered by Google App Engine
This is Rietveld 408576698