content/browser/renderer_host/render_widget_host_input_event_router.h - Issue 2186983002: Re-route Touchscreen GesturePinch events to root view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_input_event_router.h

Issue 2186983002: Re-route Touchscreen GesturePinch events to root view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address kenrb@'s comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_input_event_router.cc » ('j') | content/browser/site_per_process_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_input_event_router.h

diff --git a/content/browser/renderer_host/render_widget_host_input_event_router.h b/content/browser/renderer_host/render_widget_host_input_event_router.h

index 70f8b05b8e241715ea116565b79a6518c98a7c64..2a69955e0144519a55db0e686f6a1c8cc1b46dad 100644

--- a/content/browser/renderer_host/render_widget_host_input_event_router.h

+++ b/content/browser/renderer_host/render_widget_host_input_event_router.h

@@ -137,6 +137,8 @@ class CONTENT_EXPORT RenderWidgetHostInputEventRouter

TargetData bubbling_gesture_scroll_target_;

TargetData first_bubbling_scroll_target_;

int active_touches_;

+ bool in_touchscreen_gesture_pinch_;

Charlie Reis 2016/07/28 17:23:02 Can you add comments for these? It's a bit unfort

wjmaclean 2016/07/29 14:28:31 Done.

+ bool root_view_gesture_scrolling_;

Charlie Reis 2016/07/28 17:23:02 Is this stale? It's never initialized, and looks

wjmaclean 2016/07/29 14:28:31 Yes, thanks for catching it! Done.

std::unordered_map<cc::SurfaceId, HittestData, cc::SurfaceIdHash>

hittest_data_;

« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_input_event_router.cc » ('j') | content/browser/site_per_process_browsertest.cc » ('J')