Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2187)

Unified Diff: Source/web/WebFrameImpl.cpp

Issue 218693003: Generate FrameTree::uniqueName with a URL attribute value. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove unload handler Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/FrameTree.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebFrameImpl.cpp
diff --git a/Source/web/WebFrameImpl.cpp b/Source/web/WebFrameImpl.cpp
index 96837b342d43cf35bb245fdae7df6b50821393ad..5ba2714b8e31fb4822c4aaf337584f1c063c0d93 100644
--- a/Source/web/WebFrameImpl.cpp
+++ b/Source/web/WebFrameImpl.cpp
@@ -1688,7 +1688,11 @@ PassRefPtr<LocalFrame> WebFrameImpl::createChildFrame(const FrameLoadRequest& re
RefPtr<LocalFrame> childFrame = LocalFrame::create(&webframe->m_frameLoaderClientImpl, frame()->host(), ownerElement);
webframe->setWebCoreFrame(childFrame);
- childFrame->tree().setName(request.frameName());
+ // FIXME: Using subResourceAttributeName as fallback is not a perfect
+ // solution. subResourceAttributeName returns just one attribute name. The
+ // element might not have the attribute, and there might be other attributes
+ // which can identify the element.
+ childFrame->tree().setName(request.frameName(), ownerElement->getAttribute(ownerElement->subResourceAttributeName()));
// FIXME: This comment is not quite accurate anymore.
// LocalFrame::init() can trigger onload event in the parent frame,
« no previous file with comments | « Source/core/page/FrameTree.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698