third_party/WebKit/LayoutTests/editing/spelling/markers.html - Issue 2186923002: Remove grammar checking from layout tests, and MockGrammarCheck

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/spelling/markers.html

Issue 2186923002: Remove grammar checking from layout tests, and MockGrammarCheck (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RemoveGrammarTests

Patch Set: Rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers-expected.txt ('k') | third_party/WebKit/LayoutTests/editing/spelling/markers-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/editing/spelling/markers.html

diff --git a/third_party/WebKit/LayoutTests/editing/spelling/markers.html b/third_party/WebKit/LayoutTests/editing/spelling/markers.html

index bb0b7f455f17373f67c367d621a7b58d60bca047..fe97fd888e58ab47678e3181db91c5e8b2b8ec27 100644

--- a/third_party/WebKit/LayoutTests/editing/spelling/markers.html

+++ b/third_party/WebKit/LayoutTests/editing/spelling/markers.html

@@ -14,7 +14,7 @@

<body>

-description("Tests spelling and grammar markers for misspellings.");

+description("Tests spelling markers for misspellings.");

jsTestIsAsync = true;

@@ -38,14 +38,11 @@ function typeText(elem, text) {

var container = document.getElementById('container');

-var elementWithGrammarIssue = createEditableElement(container);

-typeText(elementWithGrammarIssue, 'I have a issue.');

var elementWithSpellingIssue = createEditableElement(container);

typeText(elementWithSpellingIssue, 'zz.');

-var elementWithGrammarAndSpellingIssue = createEditableElement(container);

-typeText(elementWithGrammarAndSpellingIssue, 'orange,zz,apple.');

+var elementAlsoWithSpellingIssue = createEditableElement(container);

+typeText(elementAlsoWithSpellingIssue, 'orange,zz,apple.');

var element;

var next;

@@ -68,15 +65,12 @@ function verifyMarkers(e, misspellings) {

}

var misspellings = [

- { marker:'grammar', issue:'a' },

{ marker:'spelling', issue:'zz' },

- { marker:'grammar', issue:'orange,zz,apple.' }

];

var tests = [

- function() { verifyMarkers(elementWithGrammarIssue, misspellings.slice(0, 1)) },

- function() { verifyMarkers(elementWithSpellingIssue, misspellings.slice(1, 2)) },

- function() { verifyMarkers(elementWithGrammarAndSpellingIssue, misspellings.slice(1, 3)) },

+ function() { verifyMarkers(elementWithSpellingIssue, misspellings.slice(0, 1)) },

+ function() { verifyMarkers(elementAlsoWithSpellingIssue, misspellings.slice(0, 1)) },

];

function done()