Eliminate ash::Shell access in ShelfView

Eliminate ash::Shell access in ShelfView

This is a small step toward conversion it to ash common types.

BUG=615155
TEST=manual, show context menu and change auto-hide and alignment options,
plus ash_unittests

Committed: https://crrev.com/115925742b8a33a7178f701d54a7edc1165e35c9
Cr-Commit-Position: refs/heads/master@{#408261}

[James Cook, 2016-07-27 22:27:31]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 22:27:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-07-27 22:27:45]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-07-27 22:27:46]

msw, please take a look

[msw, 2016-07-27 22:45:11]

lgtm with a q

https://codereview.chromium.org/2186913003/diff/1/ash/shelf/shelf_view.cc
File ash/shelf/shelf_view.cc (right):

https://codereview.chromium.org/2186913003/diff/1/ash/shelf/shelf_view.cc#new...
ash/shelf/shelf_view.cc:1383: wm_shelf_->UpdateVisibilityState();
q: ok to only update this shelf, not all (like Shell::UpdateShelfVisibility)?

[James Cook, 2016-07-27 22:54:02]

https://codereview.chromium.org/2186913003/diff/1/ash/shelf/shelf_view.cc
File ash/shelf/shelf_view.cc (right):

https://codereview.chromium.org/2186913003/diff/1/ash/shelf/shelf_view.cc#new...
ash/shelf/shelf_view.cc:1383: wm_shelf_->UpdateVisibilityState();
On 2016/07/27 22:45:11, msw wrote:
> q: ok to only update this shelf, not all (like Shell::UpdateShelfVisibility)?

Yes. The overflow bubble is only associated with the current shelf and there's
nothing I can find that needs to be updated for other displays.

[James Cook, 2016-07-27 22:54:07]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2016-07-27 22:54:12]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-07-27 22:54:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 23:06:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-27 23:08:02]

Description was changed from

==========
Eliminate ash::Shell access in ShelfView

This is a small step toward conversion it to ash common types.

BUG=615155
TEST=manual, show context menu and change auto-hide and alignment options,
plus ash_unittests
==========

to

==========
Eliminate ash::Shell access in ShelfView

This is a small step toward conversion it to ash common types.

BUG=615155
TEST=manual, show context menu and change auto-hide and alignment options,
plus ash_unittests

Committed: https://crrev.com/115925742b8a33a7178f701d54a7edc1165e35c9
Cr-Commit-Position: refs/heads/master@{#408261}
==========

[commit-bot: I haz the power, 2016-07-27 23:08:02]

Patchset 1 (id:??) landed as
https://crrev.com/115925742b8a33a7178f701d54a7edc1165e35c9
Cr-Commit-Position: refs/heads/master@{#408261}