tools/json_schema_compiler/feature_compiler.py - Issue 2186893002: Reduce size of generated extension FeatureProviders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/feature_compiler.py

Issue 2186893002: Reduce size of generated extension FeatureProviders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/json_schema_compiler/feature_compiler.py

diff --git a/tools/json_schema_compiler/feature_compiler.py b/tools/json_schema_compiler/feature_compiler.py

index 7970d472ea0ca5435b8189bff3be48113422e20d..6afe9eac23af11f3d67187ea917be46a586c36ea 100644

--- a/tools/json_schema_compiler/feature_compiler.py

+++ b/tools/json_schema_compiler/feature_compiler.py

@@ -498,7 +498,7 @@ class FeatureCompiler(object):

c.Append('feature->set_name("%s");' % k)

else:

c.Concat(feature.GetCode(self._feature_class))

- c.Append('features_["%s"] = std::move(feature);' % k)

+ c.Append('AddFeature("%s", std::move(feature));' % k)

c.Eblock('}')

return c

« no previous file with comments | « extensions/common/features/simple_feature.cc ('k') | no next file » | no next file with comments »