Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: extensions/common/features/feature.h

Issue 2186893002: Reduce size of generated extension FeatureProviders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/features/base_feature_provider.cc ('k') | extensions/common/features/feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/features/feature.h
diff --git a/extensions/common/features/feature.h b/extensions/common/features/feature.h
index 5b85bb28bc280eb0043230b8a0c3eb16d054507d..a570b9a93f7f62db0bd4cf2880551303635fdf03 100644
--- a/extensions/common/features/feature.h
+++ b/extensions/common/features/feature.h
@@ -8,6 +8,7 @@
#include <set>
#include <string>
+#include "base/strings/string_piece.h"
#include "base/values.h"
#include "extensions/common/manifest.h"
@@ -102,7 +103,9 @@ class Feature {
virtual ~Feature();
const std::string& name() const { return name_; }
- void set_name(const std::string& name) { name_ = name; }
+ // Note that this arg is passed as a StringPiece to avoid a lot of bloat from
+ // inlined std::string code.
+ void set_name(base::StringPiece name);
bool no_parent() const { return no_parent_; }
// Gets the platform the code is currently running on.
« no previous file with comments | « extensions/common/features/base_feature_provider.cc ('k') | extensions/common/features/feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698