Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2186863005: [heap] Reland "Remove black pages and use black areas instead." (Closed)

Created:
4 years, 4 months ago by Hannes Payer (out of office)
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland "Remove black pages and use black areas instead." BUG=chromium:630969, chromium:630386 Committed: https://crrev.com/205457b1aa3811021f603f8a4201b5363507841d Cr-Commit-Position: refs/heads/master@{#38195}

Patch Set 1 #

Patch Set 2 : filter out live fillers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+362 lines, -169 lines) Patch
M src/heap/heap.cc View 4 chunks +25 lines, -9 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +9 lines, -4 lines 0 comments Download
M src/heap/incremental-marking.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +13 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 11 chunks +25 lines, -70 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 1 chunk +35 lines, -9 lines 0 comments Download
M src/heap/marking.h View 2 chunks +92 lines, -19 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 3 chunks +5 lines, -14 lines 0 comments Download
M src/heap/spaces.cc View 7 chunks +58 lines, -22 lines 0 comments Download
M src/heap/spaces-inl.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -4 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M test/unittests/heap/marking-unittest.cc View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
ulan
lgtm
4 years, 4 months ago (2016-07-28 14:17:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186863005/20001
4 years, 4 months ago (2016-08-01 08:34:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-01 09:03:09 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 09:05:17 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/205457b1aa3811021f603f8a4201b5363507841d
Cr-Commit-Position: refs/heads/master@{#38195}

Powered by Google App Engine
This is Rietveld 408576698