Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2186863002: FrameLoader: add and export isReloadLoadType() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: speculative fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index 748336e8359906c0a7221561e15160e1472385cf..fc68363ee5f0e38ca68f06d6fd093f3d95e4e464 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -110,12 +110,23 @@ using namespace HTMLNames;
bool isBackForwardLoadType(FrameLoadType type)
{
- return type == FrameLoadTypeBackForward || type == FrameLoadTypeInitialHistoryLoad;
+ return type == FrameLoadTypeBackForward
+ || type == FrameLoadTypeInitialHistoryLoad;
+}
+
+bool isReloadLoadType(FrameLoadType type)
+{
+ return type == FrameLoadTypeReload
+ || type == FrameLoadTypeReloadMainResource
+ || type == FrameLoadTypeReloadBypassingCache;
}
static bool needsHistoryItemRestore(FrameLoadType type)
{
- return type == FrameLoadTypeBackForward || type == FrameLoadTypeReload
+ // TODO(toyoshim): Check if this should return true for
+ // FrameLoadTypeReloadMainResource.
+ return type == FrameLoadTypeBackForward
+ || type == FrameLoadTypeReload
|| type == FrameLoadTypeReloadBypassingCache;
}
@@ -139,7 +150,7 @@ ResourceRequest FrameLoader::resourceRequestFromHistoryItem(HistoryItem* item, W
ResourceRequest FrameLoader::resourceRequestForReload(FrameLoadType frameLoadType,
const KURL& overrideURL, ClientRedirectPolicy clientRedirectPolicy)
{
- ASSERT(frameLoadType == FrameLoadTypeReload || frameLoadType == FrameLoadTypeReloadMainResource || frameLoadType == FrameLoadTypeReloadBypassingCache);
+ DCHECK(isReloadLoadType(frameLoadType));
WebCachePolicy cachePolicy = frameLoadType == FrameLoadTypeReloadBypassingCache ? WebCachePolicy::BypassingCache : WebCachePolicy::ValidatingCacheData;
if (!m_currentItem)
return ResourceRequest();
@@ -870,7 +881,7 @@ static bool shouldOpenInNewWindow(Frame* targetFrame, const FrameLoadRequest& re
static NavigationType determineNavigationType(FrameLoadType frameLoadType, bool isFormSubmission, bool haveEvent)
{
- bool isReload = frameLoadType == FrameLoadTypeReload || frameLoadType == FrameLoadTypeReloadMainResource || frameLoadType == FrameLoadTypeReloadBypassingCache;
+ bool isReload = isReloadLoadType(frameLoadType);
bool isBackForward = isBackForwardLoadType(frameLoadType);
if (isFormSubmission)
return (isReload || isBackForward) ? NavigationTypeFormResubmitted : NavigationTypeFormSubmitted;
@@ -1295,9 +1306,7 @@ bool FrameLoader::shouldPerformFragmentNavigation(bool isFormSubmission, const S
// We don't do this if we are submitting a form with method other than "GET", explicitly reloading,
// currently displaying a frameset, or if the URL does not have a fragment.
return (!isFormSubmission || equalIgnoringCase(httpMethod, HTTPNames::GET))
- && loadType != FrameLoadTypeReload
- && loadType != FrameLoadTypeReloadBypassingCache
- && loadType != FrameLoadTypeReloadMainResource
+ && !isReloadLoadType(loadType)
&& loadType != FrameLoadTypeBackForward
&& url.hasFragmentIdentifier()
&& equalIgnoringFragmentIdentifier(m_frame->document()->url(), url)

Powered by Google App Engine
This is Rietveld 408576698