FrameLoader: add and export isReloadLoadType()

third_party/WebKit/Source/core/frame/LocalFrame.cpp

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
index 8fc2931d6b4c1b76771e0d737940d2a249debd03..2103deebe801a14651205d8ee7eaeba9c9af571e 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
@@ -356,8 +356,7 @@ void LocalFrame::navigate(const FrameLoadRequest& request)
 
 void LocalFrame::reload(FrameLoadType loadType, ClientRedirectPolicy clientRedirectPolicy)
 {
-    ASSERT(loadType == FrameLoadTypeReload || loadType == FrameLoadTypeReloadBypassingCache);
-    ASSERT(clientRedirectPolicy == ClientRedirectPolicy::NotClientRedirect || loadType == FrameLoadTypeReload);
+    DCHECK(isReloadLoadType(loadType));

[Takashi Toyoshima, 2016/07/27 10:26:48]

This isn't mechanical change, but this should allow
FrameLoadTypeReloadMainResource.

     if (clientRedirectPolicy == ClientRedirectPolicy::NotClientRedirect) {
         if (!m_loader.currentItem())
             return;
@@ -366,6 +365,7 @@ void LocalFrame::reload(FrameLoadType loadType, ClientRedirectPolicy clientRedir
         request.setClientRedirect(clientRedirectPolicy);
         m_loader.load(request, loadType);
     } else {
+        DCHECK(loadType == FrameLoadTypeReload);

[Takashi Toyoshima, 2016/07/27 10:26:48]

For me, this DCHECK is easier to understand the intention than the original
ASSERT that I was confused a little at the first glance. What do you think?

Note: ClientRedirectPolicy is binary of NotClientRedirect or ClientRedirect.

         m_navigationScheduler->scheduleReload();
     }
 }