third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.h - Issue 2186853002: WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.h

Issue 2186853002: WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated peerconnection.js (re-running trybots can wait, will need to rebase with master) Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/webrtc/peerconnection.js ('K') | « content/renderer/media/rtc_peer_connection_handler_unittest.cc ('k') | third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.h

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.h b/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.h

index f70036180e26cb459627d269283e4f7c1a1c71b2..cd58d49d403d3f51a6b15ebbc3f2ad0bf49b93fa 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.h

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.h

@@ -41,11 +41,9 @@ public:

static RTCStatsResponse* create();

const HeapVector<Member<RTCStatsReport>>& result() const { return m_result; }

RTCStatsReport* namedItem(const AtomicString& name);

- size_t addReport(const String& id, const String& type, double timestamp) override;

- void addStatistic(size_t report, const String& name, const String& value) override;

+ void addStats(const WebRTCStats&) override;

DECLARE_VIRTUAL_TRACE();