content/renderer/media/rtc_peer_connection_handler.h - Issue 2186853002: WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_peer_connection_handler.h

Issue 2186853002: WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed tommi's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/mock_webrtc_peer_connection_handler.cc ('k') | content/renderer/media/rtc_peer_connection_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/rtc_peer_connection_handler.h

diff --git a/content/renderer/media/rtc_peer_connection_handler.h b/content/renderer/media/rtc_peer_connection_handler.h

index 93ad683cbe123244e714393a6ffae37840a02641..ae173abeb4f6183e0419386500cdd5303bbba15a 100644

--- a/content/renderer/media/rtc_peer_connection_handler.h

+++ b/content/renderer/media/rtc_peer_connection_handler.h

@@ -32,6 +32,7 @@ class WebRTCAnswerOptions;

class WebRTCDataChannelHandler;

class WebRTCOfferOptions;

class WebRTCPeerConnectionHandlerClient;

+class WebRTCStats;

}

namespace content {

@@ -51,10 +52,7 @@ class CONTENT_EXPORT LocalRTCStatsResponse

}

virtual blink::WebRTCStatsResponse webKitStatsResponse() const;

- virtual size_t addReport(blink::WebString type, blink::WebString id,

- double timestamp);

- virtual void addStatistic(size_t report,

- blink::WebString name, blink::WebString value);

+ virtual void addStats(const blink::WebRTCStats& stats);

protected:

~LocalRTCStatsResponse() override {}