Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/browser/media/webrtc_browsertest_base.cc

Issue 2186853002: WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed tommi's comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/webrtc_browsertest_base.h ('k') | chrome/test/data/webrtc/peerconnection.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc_browsertest_base.cc
diff --git a/chrome/browser/media/webrtc_browsertest_base.cc b/chrome/browser/media/webrtc_browsertest_base.cc
index 2213da9f1c64c33f069546e4b51c8d60692b5003..64311b8408a433e95d471f84f7eaa4623cacab2e 100644
--- a/chrome/browser/media/webrtc_browsertest_base.cc
+++ b/chrome/browser/media/webrtc_browsertest_base.cc
@@ -460,28 +460,24 @@ bool WebRtcTestBase::OnWin8() const {
}
void WebRtcTestBase::OpenDatabase(content::WebContents* tab) const {
- std::string response = ExecuteJavascript("openDatabase()", tab);
- EXPECT_EQ("ok-database-opened", response) << "Failed to open database: "
- << response;
+ EXPECT_EQ("ok-database-opened", ExecuteJavascript("openDatabase()", tab));
}
void WebRtcTestBase::CloseDatabase(content::WebContents* tab) const {
- std::string response = ExecuteJavascript("closeDatabase()", tab);
- EXPECT_EQ("ok-database-closed", response) << "Failed to close database: "
- << response;
+ EXPECT_EQ("ok-database-closed", ExecuteJavascript("closeDatabase()", tab));
}
void WebRtcTestBase::DeleteDatabase(content::WebContents* tab) const {
- std::string response = ExecuteJavascript("deleteDatabase()", tab);
- EXPECT_EQ("ok-database-deleted", response) << "Failed to delete database: "
- << response;
+ EXPECT_EQ("ok-database-deleted", ExecuteJavascript("deleteDatabase()", tab));
}
void WebRtcTestBase::GenerateAndCloneCertificate(
content::WebContents* tab, const std::string& keygen_algorithm) const {
std::string javascript = base::StringPrintf(
"generateAndCloneCertificate(%s)", keygen_algorithm.c_str());
- std::string response = ExecuteJavascript(javascript, tab);
- EXPECT_EQ("ok-generated-and-cloned", response) << "Failed to generate and "
- "clone certificate: " << response;
+ EXPECT_EQ("ok-generated-and-cloned", ExecuteJavascript(javascript, tab));
+}
+
+void WebRtcTestBase::VerifyStatsGenerated(content::WebContents* tab) const {
+ EXPECT_EQ("ok-got-stats", ExecuteJavascript("verifyStatsGenerated()", tab));
}
« no previous file with comments | « chrome/browser/media/webrtc_browsertest_base.h ('k') | chrome/test/data/webrtc/peerconnection.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698