WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink

chrome/test/data/webrtc/peerconnection.js

 /**
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * The one and only peer connection in this page.
  * @private
  */
@@ skipping 271 matching lines @@
   returnToTest('ok-muted');
 }
 
 /**
  * Returns
  */
 function hasSeenCryptoInSdp() {
   returnToTest(gHasSeenCryptoInSdp);
 }
 
+/**
+ * Gets and iterates stats. Makes sure at least one report stat is returned.
+ *
+ * Returns ok on success.
+ */
+function getStats() {
+  peerConnection_().getStats(
+    function(response) {
+      var statsStr = '';
+      var reports = response.result();
+      var numStats = 0;
+      for (var i = 0; i < reports.length; i++) {
+        var report = reports[i];
+        statsStr += '\nReport #' + i + ': ' + report.id + ' (type: ' +

[phoglund_chromium, 2016/07/27 12:52:10]

Maybe call it statsText or result? It appears this is only used for debugging. I
think you should either analyze the string and check it contains what you
expected, or drop the whole thing from this test. The purpose of this test isn't
to debug stats but rather watch for regressions. I think you're better served by
a test page for debugging.

[hbos_chromium, 2016/07/27 13:50:31]

Done.

+            report.type + ', timestamp: ' + report.timestamp + ')';
+        var statNames = report.names();
+        numStats += statNames.length;
+        for (var j = 0; j < statNames.length; j++) {
+          var statName = statNames[j];
+          var statValue = report.stat(statName);
+          statsStr += '\n- ' + statName + ': ' + statValue;
+        }
+      }
+      console.log('getStats:' + statsStr);
+      if (numStats === 0)
+        throw failTest('No stats was returned by getStats.');
+      returnToTest('ok');

[phoglund_chromium, 2016/07/27 12:52:10]

ok-got-stats perhaps?

[hbos_chromium, 2016/07/27 13:50:31]

Done.

+    });
+}
+
 // Internals.
 
 /** @private */
 function createPeerConnection_(rtcConfig) {
   try {
     peerConnection = new RTCPeerConnection(rtcConfig, {});
   } catch (exception) {
     throw failTest('Failed to create peer connection: ' + exception);
   }
   peerConnection.onaddstream = addStreamCallback_;
@@ skipping 47 matching lines @@
 function parseJson_(json) {
   // Escape since the \r\n in the SDP tend to get unescaped.
   jsonWithEscapedLineBreaks = json.replace(/\r\n/g, '\\r\\n');
   try {
     return JSON.parse(jsonWithEscapedLineBreaks);
   } catch (exception) {
     failTest('Failed to parse JSON: ' + jsonWithEscapedLineBreaks + ', got ' +
              exception);
   }
 }