WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink

chrome/browser/media/webrtc_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/strings/stringprintf.h"
 #include "build/build_config.h"
 #include "chrome/browser/media/webrtc_browsertest_base.h"
 #include "chrome/browser/media/webrtc_browsertest_common.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 38 matching lines @@
 
     // Flag used by TestWebAudioMediaStream to force garbage collection.
     command_line->AppendSwitchASCII(switches::kJavaScriptFlags, "--expose-gc");
   }
 
   void RunsAudioVideoWebRTCCallInTwoTabs(
       const std::string& video_codec = WebRtcTestBase::kUseDefaultVideoCodec,
       const std::string& offer_cert_keygen_alg =
           WebRtcTestBase::kUseDefaultCertKeygen,
       const std::string& answer_cert_keygen_alg =
-          WebRtcTestBase::kUseDefaultCertKeygen) {
+          WebRtcTestBase::kUseDefaultCertKeygen,
+      bool get_stats = false) {

[phoglund_chromium, 2016/07/27 12:52:10]

Instead of adding a new parameter, maybe inline this function body to your new
test and just call stats verification directly from there. It's so few lines of
code it's not worth polluting this helper with more parameters.

[hbos_chromium, 2016/07/27 13:50:31]

Done.

     StartServerAndOpenTabs();
 
     SetupPeerconnectionWithLocalStream(left_tab_, offer_cert_keygen_alg);
     SetupPeerconnectionWithLocalStream(right_tab_, answer_cert_keygen_alg);
 
     NegotiateCall(left_tab_, right_tab_, video_codec);
 
+    if (get_stats)
+      GetStats(left_tab_);
+
     DetectVideoAndHangUp();
   }
 
   void RunsAudioVideoWebRTCCallInTwoTabsWithClonedCertificate(
       const std::string& cert_keygen_alg =
           WebRtcTestBase::kUseDefaultCertKeygen) {
     StartServerAndOpenTabs();
 
     // Generate and clone a certificate, resulting in JavaScript variable
     // |gCertificateClone| being set to the resulting clone.
@@ skipping 108 matching lines @@
                                     kKeygenAlgorithmRsa,
                                     kKeygenAlgorithmEcdsa);
 }
 
 IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest,
                        RunsAudioVideoWebRTCCallInTwoTabsOfferEcdsaAnswerRsa) {
   RunsAudioVideoWebRTCCallInTwoTabs(WebRtcTestBase::kUseDefaultVideoCodec,
                                     kKeygenAlgorithmEcdsa,
                                     kKeygenAlgorithmRsa);
 }
+
+IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest,
+                       RunsAudioVideoWebRTCCallInTwoTabsGetStats) {
+  RunsAudioVideoWebRTCCallInTwoTabs(WebRtcTestBase::kUseDefaultVideoCodec,
+                                    WebRtcTestBase::kUseDefaultCertKeygen,
+                                    WebRtcTestBase::kUseDefaultCertKeygen,
+                                    true);
+}