Source/core/html/forms/TextFieldInputType.cpp - Issue 218683010: Using alt and down key to open datalist using keyboard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/TextFieldInputType.cpp

Issue 218683010: Using alt and down key to open datalist using keyboard (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated as per code review commnets Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/TextFieldInputType.cpp

diff --git a/Source/core/html/forms/TextFieldInputType.cpp b/Source/core/html/forms/TextFieldInputType.cpp

index 041d0307d823880aa98a8326103e359f9742e37a..864fe847eb45e1c27e3e31e32c50472f222575f4 100644

--- a/Source/core/html/forms/TextFieldInputType.cpp

+++ b/Source/core/html/forms/TextFieldInputType.cpp

@@ -208,7 +208,7 @@ void TextFieldInputType::handleKeydownEventForSpinButton(KeyboardEvent* event)

const String& key = event->keyIdentifier();

if (key == "Up")

spinButtonStepUp();

- else if (key == "Down")

+ else if (key == "Down" && !event->altKey())

spinButtonStepDown();

else

return;

« no previous file with comments | « LayoutTests/fast/forms/number/number-keyoperation-expected.txt ('k') | no next file » | no next file with comments »