LayoutTests/fast/forms/number/number-appearance-keyboard.html - Issue 218683010: Using alt and down key to open datalist using keyboard

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/number/number-appearance-keyboard.html

Issue 218683010: Using alt and down key to open datalist using keyboard (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Test changes and avoid early return for key handling Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <datalist id="dl1">

	8 <option>100</option>

	9 </datalist>

	10 <input type="number" id="number" value="0" list="dl1">

	11 <script>

	12 description('Test alt+down does not generate stepDown.');

	13 var number = document.getElementById('number');

	14 number.focus();

	15 if (window.eventSender) {

	16 debug('Test down+alt key does not generate stepDown');

	17 eventSender.keyDown('downArrow', ['altKey']);
	keishi 2014/04/02 11:15:38 I don't think this needs to be a separate file. Al I don't think this needs to be a separate file. Also the file name doesn't make sense, we aren't testing appearance. You can add the down+alt case to number-keyoperation.html Habib Virji 2014/04/02 12:27:26 Done. Show quoted text On 2014/04/02 11:15:38, keishi1 wrote: > I don't think this needs to be a separate file. Also the file name doesn't make > sense, we aren't testing appearance. > You can add the down+alt case to number-keyoperation.html Done.
	18 shouldBeEqualToString('number.value', '0');

	19 debug('Test only down key alone generates stepDown');

	20 eventSender.keyDown('downArrow');

	21 shouldBeEqualToString('number.value', '-1');

	22 }

	23 </script>

	24 </body>

	25 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/forms/number/number-appearance-keyboard-expected.txt » ('j') | Source/core/html/forms/TextFieldInputType.cpp » ('J')